jenkins-bot has submitted this change and it was merged.
Change subject: Fix function naming conventions, comments and whitespace
......................................................................
Fix function naming conventions, comments and whitespace
* Convert some spaces to tabs
* Move private function to top and document
* Give constructor a global name
Change-Id: I7ec144303d32b1bb454b4164222601c263fb75bf
---
M modules/ve/ve.EventSequencer.js
1 file changed, 20 insertions(+), 13 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ve.EventSequencer.js b/modules/ve/ve.EventSequencer.js
index 1d0d5de..e34d8d1 100644
--- a/modules/ve/ve.EventSequencer.js
+++ b/modules/ve/ve.EventSequencer.js
@@ -30,43 +30,50 @@
*
* To fire after-event listeners promptly, the EventSequencer may need to
* listen to some events for which it has no registered on-event or
- * event-event listeners. For instance, to ensure an after-keydown listener
+ * after-event listeners. For instance, to ensure an after-keydown listener
* is be fired before the native keyup action, you must include both
* 'keydown' and 'keyup' in the eventNames Array.
*
* @constructor
* @param {string[]} eventNames List of event Names to listen to
*/
-ve.EventSequencer = function ( eventNames ) {
- var i, len, eventName, makeEventHandler, eventSequencer = this;
+ve.EventSequencer = function VeEventSequencer( eventNames ) {
+ var i, len, eventName, eventSequencer = this;
this.$node = null;
this.eventNames = eventNames;
this.eventHandlers = {};
+
+ /**
+ * Generate an event handler for a specific event
+ *
+ * @private
+ * @param {string} eventName The event's name
+ * @returns {Function} An event handler
+ */
+ function makeEventHandler( eventName ) {
+ return function ( ev ) {
+ return eventSequencer.onEvent( eventName, ev );
+ };
+ }
/**
* @property {Object[]}
* - id {number} Id for setTimeout
* - func {Function} Post-event listener
* - ev {jQuery.Event} Browser event
- * - eventName {string} Name, such as keydown
- */
+ * - eventName {string} Name, such as keydown
+ */
this.pendingCalls = [];
/**
- * @property {Object.<string,Function>}
+ * @property {Object.<string,Function>}
*/
this.onListenersForEvent = {};
/**
- * @property {Object.<string,Function>}
+ * @property {Object.<string,Function>}
*/
this.afterListenersForEvent = {};
-
- makeEventHandler = function ( eventName ) {
- return function ( ev ) {
- return eventSequencer.onEvent( eventName, ev );
- };
- };
for ( i = 0, len = eventNames.length; i < len; i++ ) {
eventName = eventNames[i];
--
To view, visit https://gerrit.wikimedia.org/r/84368
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ec144303d32b1bb454b4164222601c263fb75bf
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
