Henning Snater has submitted this change and it was merged. Change subject: Make use of latest $.ui.inputextender updates in snakview value variation ......................................................................
Make use of latest $.ui.inputextender updates in snakview value variation Using $.ui.inputextender.redrawVisibleExtensions() instead of triggering global event with jQuery. This REQUIRES I23cded705ce4954644e4e5ea58c9119f2a1e8a3e in the DataValues repo. Change-Id: I8fae7074dbea1a28246045c9eb2e03f33c400ed3 --- M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Henning Snater: Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js index 8d725f6..971fb56 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js @@ -4,12 +4,6 @@ * * @licence GNU GPL v2+ * @author Daniel Werner < [email protected] > - * - * @event animationstep: Triggered on the html element while the variation's viewport is being - * animated. - * (1) {jQuery.Event} - * (2) {Number} now - * (3) {jQuery.Tween} tween */ ( function( mw, wb, dv, dt, $ ) { 'use strict'; @@ -204,12 +198,12 @@ } var $input = $( event.target ), - $extension = $input.data( 'inputextender' ).$extension, + $extension = $input.data( 'inputextender' ).extension(), newHeight = 0; self.$viewPort.stop( true ); - if( $extension.is( ':visible' ) ) { + if( $extension ) { newHeight = $input.outerHeight() + $extension.outerHeight(); } else { var currentHeight = self.$viewPort.height(); @@ -223,8 +217,8 @@ { height: newHeight }, { duration: 250, - step: function( now, tween ) { - $( 'html' ).trigger( 'animationstep', [ now, tween ] ); + progress: function( animation, progress, remainingMs ) { + $.ui.inputextender.redrawVisibleExtensions(); } } ); -- To view, visit https://gerrit.wikimedia.org/r/77480 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fae7074dbea1a28246045c9eb2e03f33c400ed3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
