Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/84742
Change subject: Fixed "qualifiers-order" XML output
......................................................................
Fixed "qualifiers-order" XML output
(bug 54237)
Fills the "qualifiers-order" output to be rendered correctly in XML.
Change-Id: I0fe5b5f5d9009846329b6aee3be31bcdd62e56b2
---
M lib/includes/serializers/ClaimSerializer.php
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/42/84742/1
diff --git a/lib/includes/serializers/ClaimSerializer.php
b/lib/includes/serializers/ClaimSerializer.php
index ac00c7b..489e8ed 100644
--- a/lib/includes/serializers/ClaimSerializer.php
+++ b/lib/includes/serializers/ClaimSerializer.php
@@ -111,10 +111,13 @@
$serialization['qualifiers'] = $qualifiers;
$serialization['qualifiers-order'] = array();
- foreach( $qualifiers as $propertyId => $snaks ) {
- $serialization['qualifiers-order'][] =
$propertyId;
+ foreach( $claim->getQualifiers() as $snak ) {
+ $id = $snak->getPropertyId()->getPrefixedId();
+ if( !in_array( $id,
$serialization['qualifiers-order'] ) ) {
+ $serialization['qualifiers-order'][] =
$snak->getPropertyId()->getPrefixedId();
+ }
}
- $this->setIndexedTagName(
$serialization['qualifiers-order'], 'qualifiers-order' );
+ $this->setIndexedTagName(
$serialization['qualifiers-order'], 'property' );
}
$serialization['type'] = $claim instanceof Statement ?
'statement' : 'claim';
--
To view, visit https://gerrit.wikimedia.org/r/84742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fe5b5f5d9009846329b6aee3be31bcdd62e56b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
