jenkins-bot has submitted this change and it was merged.
Change subject: Performance improvement in
FetchedEntityContentSerializer::getSerialized
......................................................................
Performance improvement in FetchedEntityContentSerializer::getSerialized
Change-Id: I8e4b916395d41946bd536375eeb995df79740ede
---
M repo/includes/serializers/FetchedEntityContentSerializer.php
1 file changed, 3 insertions(+), 9 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/serializers/FetchedEntityContentSerializer.php
b/repo/includes/serializers/FetchedEntityContentSerializer.php
index 36dcb9e..b31bfbd 100644
--- a/repo/includes/serializers/FetchedEntityContentSerializer.php
+++ b/repo/includes/serializers/FetchedEntityContentSerializer.php
@@ -61,6 +61,7 @@
/** @var $entity Entity */
$entity = $entityContent->getEntity();
+ $entityTitle = $entityContent->getTitle();
$entitySerializationOptions =
$this->options->getEntitySerializationOptions();
$serializerFactory = new SerializerFactory();
@@ -69,15 +70,8 @@
$entitySerializationOptions
);
$serialization['content'] = $entitySerializer->getSerialized(
$entity );
- $serialization['title'] =
$entityContent->getTitle()->getPrefixedText();
-
- $entityPageRevision =
$entityContent->getWikiPage()->getRevision();
-
- if( !$entityPageRevision ) {
- $serialization['revision'] = '';
- } else {
- $serialization['revision'] =
$entityPageRevision->getId();
- }
+ $serialization['title'] = $entityTitle->getPrefixedText();
+ $serialization['revision'] = $entityTitle->getLatestRevID() ?:
'';
return $serialization;
}
--
To view, visit https://gerrit.wikimedia.org/r/83689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e4b916395d41946bd536375eeb995df79740ede
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
