Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/84747
Change subject: Fix variable names in newFromInsertion
......................................................................
Fix variable names in newFromInsertion
Documentation says third argument is 'data' when in fact it is
'insertion' which is then re-used as the result of fixupInsertion :/
Change-Id: I17c959f858eddddc90a6fa839da0d32da69a784f
---
M modules/ve/dm/ve.dm.Transaction.js
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/47/84747/1
diff --git a/modules/ve/dm/ve.dm.Transaction.js
b/modules/ve/dm/ve.dm.Transaction.js
index a3b9442..bf294db 100644
--- a/modules/ve/dm/ve.dm.Transaction.js
+++ b/modules/ve/dm/ve.dm.Transaction.js
@@ -29,17 +29,16 @@
* @param {Array} data Data to insert
* @returns {ve.dm.Transaction} Transaction that inserts data
*/
-ve.dm.Transaction.newFromInsertion = function ( doc, offset, insertion ) {
- var tx = new ve.dm.Transaction(),
- data = doc.data;
+ve.dm.Transaction.newFromInsertion = function ( doc, offset, data ) {
+ var insertion, tx = new ve.dm.Transaction();
// Fix up the insertion
- insertion = doc.fixupInsertion( insertion, offset );
+ insertion = doc.fixupInsertion( data, offset );
// Retain up to insertion point, if needed
tx.pushRetain( insertion.offset );
// Insert data
tx.pushReplace( doc, insertion.offset, insertion.remove, insertion.data
);
// Retain to end of document, if needed (for completeness)
- tx.pushRetain( data.getLength() - ( insertion.offset + insertion.remove
) );
+ tx.pushRetain( doc.data.getLength() - ( insertion.offset +
insertion.remove ) );
return tx;
};
--
To view, visit https://gerrit.wikimedia.org/r/84747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17c959f858eddddc90a6fa839da0d32da69a784f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
