Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/84763
Change subject: Forcing redraw of snakview variation when changing the property
......................................................................
Forcing redraw of snakview variation when changing the property
(bug 53157)
When selecting a property from the entityselector widget while another property
is set already,
the snakview's cached property id is cleared to force redrawing the snakview
variation.
Change-Id: I395bd7d851b355b69f1c8af06ce20a328af2c1d0
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/63/84763/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index 5cf74b2..f35bafa 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -212,6 +212,10 @@
// spinner when the selected item actually has not
changed since the variation will stay
// in place.
if ( !self._propertyId || self._propertyId !==
ui.item.id ) {
+ // Reset the cached property id for
re-rendering being triggered as soon as the new
+ // property's attributes have been received:
+ self.propertyId( null );
+
self.$snakValue.empty().append(
$( '<div/>' ).append( $( '<span/>'
).addClass( 'mw-small-spinner' ) )
);
--
To view, visit https://gerrit.wikimedia.org/r/84763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I395bd7d851b355b69f1c8af06ce20a328af2c1d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
