jenkins-bot has submitted this change and it was merged.
Change subject: RefreshLinksJob: Replace use of empty() with explicit check
......................................................................
RefreshLinksJob: Replace use of empty() with explicit check
Using empty() is a maintenance nightmare as it completely removes
any meaning of what the author intends to check for (whether the
variable exists at all, it being set to an empty array, 0, '0' etc.)
Follows-up I445e10da122e5f24e589 which changed it from isset()
to !empty() with commit message of checking for false.
Change-Id: I561f03b0526685f51138d723f9eb7196725e0b93
---
M includes/job/jobs/RefreshLinksJob.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/job/jobs/RefreshLinksJob.php
b/includes/job/jobs/RefreshLinksJob.php
index 474212b..4fc8bac 100644
--- a/includes/job/jobs/RefreshLinksJob.php
+++ b/includes/job/jobs/RefreshLinksJob.php
@@ -48,7 +48,7 @@
# Wait for the DB of the current/next slave DB handle to catch
up to the master.
# This way, we get the correct page_latest for templates or
files that just changed
# milliseconds ago, having triggered this job to begin with.
- if ( !empty( $this->params['masterPos'] ) ) {
+ if ( isset( $this->params['masterPos'] ) &&
$this->params['masterPos'] !== false ) {
wfGetLB()->waitFor( $this->params['masterPos'] );
}
--
To view, visit https://gerrit.wikimedia.org/r/84720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I561f03b0526685f51138d723f9eb7196725e0b93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
