Henning Snater has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/84983


Change subject: Prevent calling tooltip's hide() when reference is destroyed 
already
......................................................................

Prevent calling tooltip's hide() when reference is destroyed already

Change-Id: I7be9a615effbe1f42ea30c9f1a75a87bc7e2cfdf
---
M lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/83/84983/1

diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js 
b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
index f1c7117..96251c7 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
@@ -237,7 +237,10 @@
                        } );
 
                        $( window ).one( 'mousedown.' + this.widgetName, 
function( event ) {
-                               self.hide();
+                               // Tipsy might be destroyed already.
+                               if( self._tipsy ) {
+                                       self.hide();
+                               }
                        } );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/84983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7be9a615effbe1f42ea30c9f1a75a87bc7e2cfdf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to