Daniel Kinzler has uploaded a new change for review.
https://gerrit.wikimedia.org/r/85188
Change subject: Fix validation of snakhash parameter
......................................................................
Fix validation of snakhash parameter
Change-Id: Ib57c03fe8522f5cfb637f371423e1f93b331fa3a
---
M repo/includes/api/SetQualifier.php
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/88/85188/1
diff --git a/repo/includes/api/SetQualifier.php
b/repo/includes/api/SetQualifier.php
index bc0bbe1..1614dfd 100644
--- a/repo/includes/api/SetQualifier.php
+++ b/repo/includes/api/SetQualifier.php
@@ -3,7 +3,6 @@
namespace Wikibase\Api;
use ApiBase;
-use Wikibase\Entity;
use Wikibase\Claim;
use Wikibase\Repo\WikibaseRepo;
use Wikibase\ChangeOpQualifier;
@@ -44,7 +43,7 @@
$claim = $this->claimModificationHelper->getClaimFromEntity(
$params['claim'], $entity );
if ( isset( $params['snakhash'] ) ) {
- $this->validateReferenceHash( $claim,
$params['snakhash'] );
+ $this->validateQualifierHash( $claim,
$params['snakhash'] );
}
$changeOp = $this->getChangeOp();
@@ -95,8 +94,8 @@
* @param string $qualifierHash
*/
protected function validateQualifierHash( Claim $claim, $qualifierHash
) {
- if ( !$claim->getReferences()->hasReferenceHash( $qualifierHash
) ) {
- $this->dieUsage( "Claim does not have a qualifier with
the given hash" , 'no-such-reference' );
+ if ( !$claim->getQualifiers()->hasSnakHash( $qualifierHash ) ) {
+ $this->dieUsage( "Claim does not have a qualifier with
the given hash" , 'no-such-qualifier' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/85188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib57c03fe8522f5cfb637f371423e1f93b331fa3a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
