jenkins-bot has submitted this change and it was merged.
Change subject: Cleanup after cookie name change
......................................................................
Cleanup after cookie name change
mf_mobileFormat changed to mf_useformat in
1fb258a0df8e9bb7cbbee57c3ecb7f0ea81914f0
Change-Id: I6da48c68ef536e8105970dc4db10101ece8c9156
---
M javascripts/modules/mf-stop-mobile-redirect.js
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/mf-stop-mobile-redirect.js
b/javascripts/modules/mf-stop-mobile-redirect.js
index 9d7b03a..8d7b485 100644
--- a/javascripts/modules/mf-stop-mobile-redirect.js
+++ b/javascripts/modules/mf-stop-mobile-redirect.js
@@ -1,9 +1,9 @@
/**
* Handle cookies for switching from mobile -> desktop mode
*
- * Sets stopMobileRedirect cookie and, if present, unsets the mf_mobileFormat
- * cookie (which is used on sites that do not have a separate mobile domain
- * to keep users on the mobile version of the site).
+ * Sets stopMobileRedirect cookie and, if present, unsets the cookie defined
+ * by wgUseFormatCookie (which is used on sites that do not have a separate
+ * mobile domain to keep users on the mobile version of the site).
*
* We have backend code to handle this too, however if a user is sent to a
* cached page, the PHP code that handles this will not get executed. Hence
@@ -18,11 +18,11 @@
writeCookie = M.settings.writeCookie;
function desktopViewClick() {
- // get mf_mobileFormat cookie info
+ // get info from cookie defined by wgUseFormatCookie
var useFormatCookie = mw.config.get( 'wgUseFormatCookie' ),
redirectCookie = mw.config.get(
'wgStopMobileRedirectCookie' );
- // expire the mf_mobileFormat cookie
+ // expire the cookie defined by wgUseFormatCookie
writeCookie( useFormatCookie.name, '', useFormatCookie.duration,
useFormatCookie.path, useFormatCookie.domain );
--
To view, visit https://gerrit.wikimedia.org/r/85124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6da48c68ef536e8105970dc4db10101ece8c9156
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
