Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/85914
Change subject: Regression: Exit talk after a successful save of a new topic
......................................................................
Regression: Exit talk after a successful save of a new topic
Currently takes you back to parent overlay and it looks like nothing
was added. appendSection function looks broken so removing for time
being
Change-Id: Iee10d9a4eec4d750b5dbb800cb10dc8b68314e66
---
M javascripts/modules/talk/TalkOverlay.js
1 file changed, 3 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/14/85914/1
diff --git a/javascripts/modules/talk/TalkOverlay.js
b/javascripts/modules/talk/TalkOverlay.js
index 5e7fea3..dcd816d 100644
--- a/javascripts/modules/talk/TalkOverlay.js
+++ b/javascripts/modules/talk/TalkOverlay.js
@@ -46,8 +46,10 @@
text: text + ' ~~~~'
} ).done( function() {
self.hide();
+ // close the list of
topics overlay as well
+ self.parent.hide();
+ // FIXME: give nicer
user experience - toast message would be nice at least!
M.pageApi.invalidatePage( self.title );
-
self.talkOverlay.appendSection( { heading: heading, content: text } ); //
FIXME: doesn't add signature and doesn't wikify
} );
} );
} else {
@@ -66,14 +68,6 @@
defaults: {
heading: mw.msg(
'mobile-frontend-talk-overlay-header' ),
leadHeading: mw.msg(
'mobile-frontend-talk-overlay-lead-header' )
- },
- appendSection: function( heading, text ) {
- var $newTopic;
- this.options.page.appendSection( heading, text
);
- this.render( this.options );
- $newTopic = this.$( 'li' ).last();
- window.scrollTo( 0, $newTopic.offset().top );
- // FIXME: add fade in animation
},
preRender: function( options ) {
var page = options.page,
--
To view, visit https://gerrit.wikimedia.org/r/85914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee10d9a4eec4d750b5dbb800cb10dc8b68314e66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
