jenkins-bot has submitted this change and it was merged.

Change subject: Adding a space character between links in the special page 
......................................................................


Adding a space character between links in the special page 

I did it in order to avoid bad rendering in languages like Persian

Languages like Persian has different rendering of a character in cases of they
are joined or separated. Browsers consider last character joined instead of 
separated and renders it incorrectly for example you can see the bug.

I tested it in tools.wmflabs.org/wikitest-rtl/w/index.php and it worked
properly for the Persian language.

Bug: 53488
Change-Id: I0346567d9234e5568effcfc6ce9051839ed3ed43
---
M SpecialArticleFeedbackv5.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Matthias Mullie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialArticleFeedbackv5.php b/SpecialArticleFeedbackv5.php
index 784a52c..9a7fb84 100644
--- a/SpecialArticleFeedbackv5.php
+++ b/SpecialArticleFeedbackv5.php
@@ -276,11 +276,11 @@
                                Linker::link(
                                        $this->title,
                                        $this->msg( 
'articlefeedbackv5-go-to-article' )->escaped()
-                               ) .
+                               ) . ' ' .
                                Linker::link(
                                        $this->title->getTalkPage(),
                                        $this->msg( 
'articlefeedbackv5-discussion-page' )->escaped()
-                               ) .
+                               ) . ' ' .
                                Html::element(
                                        'a',
                                        array(

-- 
To view, visit https://gerrit.wikimedia.org/r/84216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0346567d9234e5568effcfc6ce9051839ed3ed43
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Ebrahim <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Peachey88 <[email protected]>
Gerrit-Reviewer: Tychay <[email protected]>
Gerrit-Reviewer: ZxxZxxZ <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to