Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86348
Change subject: WIP: Add a check that the statsbars don't appear
......................................................................
WIP: Add a check that the statsbars don't appear
Follow up to Id2122d42ddbc7a1c78775674d93c9e407e398551
Change-Id: I25b398e565be3e6107fba2a0699fd935ce63af24
---
M tests/browser/features/signed_in_source_language.feature
M tests/browser/features/step_definitions/signed_in_source_language_steps.rb
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage
refs/changes/48/86348/1
diff --git a/tests/browser/features/signed_in_source_language.feature
b/tests/browser/features/signed_in_source_language.feature
index 51681dc..3126a4b 100644
--- a/tests/browser/features/signed_in_source_language.feature
+++ b/tests/browser/features/signed_in_source_language.feature
@@ -13,6 +13,7 @@
Then I should see statistics about myself across all languages
And I should see a language selector above project tiles
And I should see the number of messages in the project tiles
+ And I should not see statsbars in the project tiles
Scenario: English cannot be selected as the translation target language
When I click on the project language selector
@@ -21,7 +22,7 @@
Scenario: Selecting another language for project tiles
When I choose "Polish" on the project language selector
Then I should not see the number of messages in the project tiles
- And I should see a statsbars in the project tiles
+ And I should see statsbars in the project tiles
Scenario: The list of messages for translation should be in the newly
selected target language
When I choose "Polish" on the project language selector
diff --git
a/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
b/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
index 941f18b..e571a29 100644
--- a/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
+++ b/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
@@ -37,10 +37,15 @@
on(MainPage).project_tile_element.div(class:
'project-statstext').text.should == ''
end
-When(/^I should see a statsbars in the project tiles$/) do
+When(/^I should see statsbars in the project tiles$/) do
on(MainPage).project_tile_element.div(class:
'tux-statsbar').when_present.should be_visible
end
+When(/^I should not see statsbars in the project tiles$/) do
+ pending
+ # on(MainPage).project_tile_element.div(class:
'tux-statsbar').should_not be_visible
+end
+
Then(/^the target language is Polish$/) do
on(TranslatePage).target_language.should == 'polski'
end
--
To view, visit https://gerrit.wikimedia.org/r/86348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25b398e565be3e6107fba2a0699fd935ce63af24
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits