Shirayuki has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86354
Change subject: Fix spelling "sizable" (American English)
......................................................................
Fix spelling "sizable" (American English)
Simplify comments for grep
Change-Id: I8d0126dd0447b2d8c69625d24e02b2b2e59cc35c
---
M ReaderFeedback.class.php
M ReaderFeedback.hooks.php
M ReaderFeedbackXML.php
M language/RatedPages.i18n.php
M specialpages/RatingHistory_body.php
5 files changed, 10 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReaderFeedback
refs/changes/54/86354/1
diff --git a/ReaderFeedback.class.php b/ReaderFeedback.class.php
index d43f8ec..e1ed795 100644
--- a/ReaderFeedback.class.php
+++ b/ReaderFeedback.class.php
@@ -212,8 +212,7 @@
$ave = '-'; // DIV by zero
}
// @todo FIXME: severe i18n issues.
- // Give grep a chance to find the usages:
- // readerfeedback-reliability,
readerfeedback-completeness,
+ // Messages: readerfeedback-reliability,
readerfeedback-completeness,
// readerfeedback-npov, readerfeedback-presentation
$html .= '<td
align="center"><b>'.wfMessage("readerfeedback-$tag")->escaped().'</b>  '.
'<sup>('.wfMessage('ratinghistory-ave')->numParams($ave)->escaped().')</sup></td>';
diff --git a/ReaderFeedback.hooks.php b/ReaderFeedback.hooks.php
index c183f86..886612d 100644
--- a/ReaderFeedback.hooks.php
+++ b/ReaderFeedback.hooks.php
@@ -124,8 +124,7 @@
$form .= Xml::openElement( 'span', array('id' =>
'mw-feedbackselects') );
# Loop through all different flag types
foreach( ReaderFeedback::getFeedbackTags() as $quality =>
$levels ) {
- // Give grep a chance to find the usages:
- // readerfeedback-reliability,
readerfeedback-completeness,
+ // Messages: readerfeedback-reliability,
readerfeedback-completeness,
// readerfeedback-npov, readerfeedback-presentation
$selected = ( isset($flags[$quality]) &&
$flags[$quality] > 0 ) ? $flags[$quality] : -1;
$form .= "<b>" . Xml::label(
wfMessage("readerfeedback-$quality")->escaped(), "wp$quality" ) . ":</b>";
@@ -134,9 +133,8 @@
$form .= ' ' . Xml::openElement( 'select',
$attribs );
$levels = array_reverse($levels,true);
foreach( $levels as $i => $name ) {
- // Give grep a chance to find the usages:
- // readerfeedback-level-0,
readerfeedback-level-1, readerfeedback-level-2,
- // readerfeedback-level-3,
readerfeedback-level-4
+ // Messages: readerfeedback-level-0,
readerfeedback-level-1,
+ // readerfeedback-level-2,
readerfeedback-level-3, readerfeedback-level-4
$optionClass = array( 'class' =>
"rfb-rating-option-$i" );
$form .= Xml::option(
wfMessage("readerfeedback-level-$i")->text(), $i, ($i == $selected),
$optionClass ) ."\n";
}
diff --git a/ReaderFeedbackXML.php b/ReaderFeedbackXML.php
index 9cc8cb5..62553eb 100644
--- a/ReaderFeedbackXML.php
+++ b/ReaderFeedbackXML.php
@@ -46,8 +46,7 @@
* @return string
*/
public static function getTagMenu( $selected = '' ) {
- // Give grep a chance to find the usages:
- // readerfeedback-reliability, readerfeedback-completeness,
+ // Messages: readerfeedback-reliability,
readerfeedback-completeness,
// readerfeedback-npov, readerfeedback-presentation
$s = "<label for='wpRatingTag'>" .
wfMessage('readerfeedback-tagfilter' )->escaped() . "</label> ";
$s .= Xml::openElement( 'select', array('name' => 'ratingtag',
'id' => 'wpRatingTag') );
diff --git a/language/RatedPages.i18n.php b/language/RatedPages.i18n.php
index 5c73f24..9989557 100644
--- a/language/RatedPages.i18n.php
+++ b/language/RatedPages.i18n.php
@@ -9,7 +9,7 @@
$messages['en'] = array(
'ratedpages' => 'Reader rated pages',
- 'ratedpages-leg' => 'Find pages rated with a sizeable number of
ratings',
+ 'ratedpages-leg' => 'Find pages rated with a sizable number of
ratings',
'ratedpages-list' => 'Below is a list of pages sorted by their reader
feedback rating.',
'ratedpages-none' => 'There are no pages in this list.',
'ratedpages-graphs' => 'rating data',
diff --git a/specialpages/RatingHistory_body.php
b/specialpages/RatingHistory_body.php
index bd51646..d325c4d 100644
--- a/specialpages/RatingHistory_body.php
+++ b/specialpages/RatingHistory_body.php
@@ -132,8 +132,7 @@
{
case 'svg':
if( $exists ) {
- // Give grep a chance to find the
usages:
- // readerfeedback-reliability,
readerfeedback-completeness,
+ // Messages:
readerfeedback-reliability, readerfeedback-completeness,
// readerfeedback-npov,
readerfeedback-presentation
$html .= "<h3>" .
$this->msg("readerfeedback-$tag")->escaped() . "</h3>\n" .
Xml::openElement( 'div',
array('class' => 'rfb-reader_feedback_graph') ) .
@@ -152,8 +151,7 @@
$viewLink = " <small>[<a
href='".htmlspecialchars($svgUrl)."'>".
$this->msg("ratinghistory-svg")->escaped() . "</a>]</small>";
}
- // Give grep a chance to find the
usages:
- // readerfeedback-reliability,
readerfeedback-completeness,
+ // Messages:
readerfeedback-reliability, readerfeedback-completeness,
// readerfeedback-npov,
readerfeedback-presentation
$html .= "<h3>" .
$this->msg("readerfeedback-$tag")->escaped() . "$viewLink</h3>\n" .
Xml::openElement( 'div',
array('class' => 'rfb-reader_feedback_graph') ) .
@@ -164,8 +162,7 @@
}
break;
default: // use html table
- // Give grep a chance to find the usages:
- // readerfeedback-reliability,
readerfeedback-completeness,
+ // Messages: readerfeedback-reliability,
readerfeedback-completeness,
// readerfeedback-npov,
readerfeedback-presentation
if( $exists ) {
$fp = fopen( $filePath, 'r' );
@@ -465,8 +462,7 @@
$plot->format['dcount'] = array( 'style' => 'stroke:red;
stroke-width:1;' );
#'attributes' => "marker-end='url(#circle)'");
$pageText = $wgContLang->truncate(
$this->page->getPrefixedText(), 65 );
- // Give grep a chance to find the usages:
- // readerfeedback-reliability, readerfeedback-completeness,
+ // Messages: readerfeedback-reliability,
readerfeedback-completeness,
// readerfeedback-npov, readerfeedback-presentation
$plot->title = $this->msg('ratinghistory-graph' )->numParams(
$totalCount )
->params($this->msg("readerfeedback-$tag")->inContentLanguage()->text(),
$pageText )
--
To view, visit https://gerrit.wikimedia.org/r/86354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d0126dd0447b2d8c69625d24e02b2b2e59cc35c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReaderFeedback
Gerrit-Branch: master
Gerrit-Owner: Shirayuki <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
