Xqt has submitted this change and it was merged.
Change subject: Implement reading of Wikibase "ranks"
......................................................................
Implement reading of Wikibase "ranks"
Change-Id: Ibd8f441b4e8612936f5bca6572ba76a7b6899c2f
---
M pywikibot/page.py
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
diff --git a/pywikibot/page.py b/pywikibot/page.py
index d861832..ff2f5a2 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -2755,6 +2755,7 @@
self.qualifiers = {}
self.target = None
self.snaktype = 'value'
+ self.rank = 'normal'
self.on_item = None # The item it's on
@staticmethod
@@ -2784,6 +2785,8 @@
else:
#This covers string type
claim.target = data['mainsnak']['datavalue']['value']
+ if 'rank' in data: # References/Qualifiers don't have ranks
+ claim.rank = data['rank']
if 'references' in data:
for source in data['references']:
claim.sources.append(Claim.referenceFromJSON(site, source))
@@ -2872,6 +2875,15 @@
else:
raise ValueError("snaktype must be 'value', 'somevalue', or
'novalue'.")
+ def getRank(self):
+ return self.rank
+
+ def setRank(self):
+ """
+ Has not been implemented in the Wikibase API yet
+ """
+ raise NotImplementedError
+
def changeSnakType(self, value=None, **kwargs):
"""
This actually saves the new snakvalue.
--
To view, visit https://gerrit.wikimedia.org/r/85114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd8f441b4e8612936f5bca6572ba76a7b6899c2f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
