[MediaWiki-commits] [Gerrit] Remove CategoryTree integration tests - change (mediawiki...Cite)

[Code Review]

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/86371


Change subject: Remove CategoryTree integration tests
......................................................................

Remove CategoryTree integration tests

Test, rather. It does more harm than good, making Cite annoying to
test in isolation (breaking on WMF jenkins setup) and doesn't really
add much value. The clearState() behavior fixed per bug 20748 should
be tested with a regular PHPUnit test, if anything.

Bug: 54126
Change-Id: I6b65ef7280f95a537f25b7f5c9e57434c21357dd
---
M Cite.php
D citeCatTreeParserTests.txt
2 files changed, 0 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/71/86371/1

diff --git a/Cite.php b/Cite.php
index 3f07794..4b2f70f 100644
--- a/Cite.php
+++ b/Cite.php
@@ -29,7 +29,6 @@
        'url' => 'https://www.mediawiki.org/wiki/Extension:Cite/Cite.php'
 );
 $wgParserTestFiles[] = __DIR__ . "/citeParserTests.txt";
-$wgParserTestFiles[] = __DIR__ . "/citeCatTreeParserTests.txt";
 $wgExtensionMessagesFiles['Cite'] = __DIR__ . "/Cite.i18n.php";
 $wgAutoloadClasses['Cite'] = __DIR__ . "/Cite_body.php";
 $wgSpecialPageGroups['Cite'] = 'pagetools';
diff --git a/citeCatTreeParserTests.txt b/citeCatTreeParserTests.txt
deleted file mode 100644
index 41362e6..0000000
--- a/citeCatTreeParserTests.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-# Force the test runner to ensure the extension is loaded
-!! hooks
-ref
-references
-categorytree
-!! endhooks
-
-!! test 
-Bug 20748 - <references /> doesn't work after category tree in some cases
-!! input
-<ref>ref</ref>
-
-<categorytree showcount=on>Articles tagged for deletion and 
rescue</categorytree>
-<references />
-!! result
-<p><sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
-</p>
-<div class="CategoryTreeTag" data-ct-mode="0" 
data-ct-options="{&quot;mode&quot;:0,&quot;hideprefix&quot;:20,&quot;showcount&quot;:true,&quot;namespaces&quot;:false}"><div
 class="CategoryTreeSection"><div class="CategoryTreeItem"><span 
class="CategoryTreeEmptyBullet">[<b>×</b>] </span> <a class="CategoryTreeLabel  
CategoryTreeLabelNs14 new CategoryTreeLabelCategory" 
href="/index.php?title=Category:Articles_tagged_for_deletion_and_rescue&amp;action=edit&amp;redlink=1">Articles
 tagged for deletion and rescue</a>‎ <span title="Contains 0 subcategories, 0 
pages, and 0 files" dir="ltr">(empty)</span></div>
-               <div class="CategoryTreeChildren" style="display:block"><i 
class="CategoryTreeNotice">no subcategories</i></div></div>
-               </div>
-<ol class="references">
-<li id="cite_note-0"><span class="mw-cite-backlink"><a 
href="#cite_ref-0">↑</a></span> <span class="reference-text">ref</span>
-</li>
-</ol>
-
-!! end
-

-- 
To view, visit https://gerrit.wikimedia.org/r/86371
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b65ef7280f95a537f25b7f5c9e57434c21357dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits