DrTrigon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/86374


Change subject: re-enable support for svn repo revision detection
......................................................................

re-enable support for svn repo revision detection

* re-enable old code still there
* add support for git sha hash (cf. change 85523)

Change-Id: I0aa62bc722df77d06c6e0bc10b87c4d284c63ede
---
M pywikibot/version.py
1 file changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat 
refs/changes/74/86374/1

diff --git a/pywikibot/version.py b/pywikibot/version.py
index 115b1a9..be7356a 100644
--- a/pywikibot/version.py
+++ b/pywikibot/version.py
@@ -47,7 +47,10 @@
     if cache:
         return cache
     try:
-        (tag, rev, date, hsh) = getversion_git()
+        if os.path.isdir('.svn'):
+            (tag, rev, date, hsh) = getversion_svn()
+        else:
+            (tag, rev, date, hsh) = getversion_git()
     except Exception:
         try:
             (tag, rev, date, hsh) = getversion_nightly()
@@ -87,11 +90,12 @@
         from sqlite3 import dbapi2 as sqlite
         con = sqlite.connect(os.path.join(_program_dir, ".svn/wc.db"))
         cur = con.cursor()
-        cur.execute('''select local_relpath, repos_path, revision, 
changed_date from nodes order by revision desc, changed_date desc''')
-        name, tag, rev, date = cur.fetchone()
+        cur.execute('''select local_relpath, repos_path, revision, 
changed_date, checksum from nodes order by revision desc, changed_date desc''')
+        name, tag, rev, date, hsh = cur.fetchone()
         con.close()
         tag = tag[:-len(name)]
         date = time.gmtime(date / 1000000)
+        hsh = hsh.split('$')[2]
     else:
         for i in xrange(3):
             entries.readline()
@@ -104,9 +108,10 @@
         date = time.strptime(entries.readline()[:19], '%Y-%m-%dT%H:%M:%S')
         rev = entries.readline()[:-1]
         entries.close()
+        hsh = '(unknown)'
     if (not date or not tag or not rev) and not path:
         raise ParseError
-    return (tag, rev, date)
+    return (tag, rev, date, hsh)
 
 
 def getversion_git(path=None):

-- 
To view, visit https://gerrit.wikimedia.org/r/86374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0aa62bc722df77d06c6e0bc10b87c4d284c63ede
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to