jenkins-bot has submitted this change and it was merged.
Change subject: Add back serialize() calls for internal errors
......................................................................
Add back serialize() calls for internal errors
For a value of the incorrect type, the type in question is a
relevant part of the error message.
Follows-up Ie0271de755a63fcda8a3671cc115af7bc931a02b.
Change-Id: I09d9f1975bdfabffe44a6f69b5296cdcbf03a51e
---
M Cite_body.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adamw: Looks good to me, but someone else must approve
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Cite_body.php b/Cite_body.php
index a7c6a4d..3c462c6 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -289,7 +289,7 @@
# Not clear how we could get here, but something is probably
# wrong with the types. Let's fail fast.
- throw new MWException( 'Invalid $str and/or $key' );
+ throw new MWException( 'Invalid $str and/or $key: ' .
serialize( array( $str, $key ) ) );
}
/**
@@ -443,7 +443,7 @@
);
}
} else {
- throw new MWException( 'Invalid stack key' );
+ throw new MWException( 'Invalid stack key: ' .
serialize( $key ) );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/86372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09d9f1975bdfabffe44a6f69b5296cdcbf03a51e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
