Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86426
Change subject: Added tests for equals method to DataItemTest
......................................................................
Added tests for equals method to DataItemTest
Change-Id: I260f2383d2db915a4aa349cdf26ada9eb511744f
---
M tests/phpunit/includes/dataitems/DIConceptTest.php
M tests/phpunit/includes/dataitems/DIPropertyTest.php
M tests/phpunit/includes/dataitems/DI_BlobTest.php
M tests/phpunit/includes/dataitems/DI_BoolTest.php
M tests/phpunit/includes/dataitems/DI_GeoCoordTest.php
M tests/phpunit/includes/dataitems/DI_NumberTest.php
M tests/phpunit/includes/dataitems/DataItemTest.php
7 files changed, 20 insertions(+), 24 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki
refs/changes/26/86426/1
diff --git a/tests/phpunit/includes/dataitems/DIConceptTest.php
b/tests/phpunit/includes/dataitems/DIConceptTest.php
index 7760ad6..b9d0312 100644
--- a/tests/phpunit/includes/dataitems/DIConceptTest.php
+++ b/tests/phpunit/includes/dataitems/DIConceptTest.php
@@ -3,24 +3,14 @@
namespace SMW\Tests;
/**
- * Tests for the SMW\DIConcept class
- *
- * @file
- *
- * @license GNU GPL v2+
- * @since 1.9
- *
- * @author mwjames
- */
-
-/**
* @covers \SMW\DIConcept
- *
- * @ingroup Test
*
* @group SMW
* @group SMWExtension
* @group SMWDataItems
+ *
+ * @license GNU GPL v2+
+ * @author mwjames
*/
class DIConceptTest extends DataItemTest {
diff --git a/tests/phpunit/includes/dataitems/DIPropertyTest.php
b/tests/phpunit/includes/dataitems/DIPropertyTest.php
index 9dfd5b0..65f2213 100644
--- a/tests/phpunit/includes/dataitems/DIPropertyTest.php
+++ b/tests/phpunit/includes/dataitems/DIPropertyTest.php
@@ -6,12 +6,6 @@
* @covers \SMW\DIProperty
* @covers SMWDataItem
*
- * @file
- * @since 1.8\SMW\DIProperty
- *
- * @ingroup SMW
- * @ingroup Test
- *
* @group SMW
* @group SMWExtension
* @group SMWDataItems
diff --git a/tests/phpunit/includes/dataitems/DI_BlobTest.php
b/tests/phpunit/includes/dataitems/DI_BlobTest.php
index b91efa4..1346ee1 100644
--- a/tests/phpunit/includes/dataitems/DI_BlobTest.php
+++ b/tests/phpunit/includes/dataitems/DI_BlobTest.php
@@ -5,7 +5,6 @@
/**
* @covers SMWDIBlob
* @covers SMWDataItem
- * Tests for the SMWDIBlob class.
*
* @file
* @since 1.8
@@ -47,4 +46,4 @@
);
}
-}
\ No newline at end of file
+}
diff --git a/tests/phpunit/includes/dataitems/DI_BoolTest.php
b/tests/phpunit/includes/dataitems/DI_BoolTest.php
index 1d52cc5..d965cee 100644
--- a/tests/phpunit/includes/dataitems/DI_BoolTest.php
+++ b/tests/phpunit/includes/dataitems/DI_BoolTest.php
@@ -5,7 +5,6 @@
/**
* @covers SMWDIBoolean
* @covers SMWDataItem
- * Tests for the SMWDIBoolean class.
*
* @file
* @since 1.8
diff --git a/tests/phpunit/includes/dataitems/DI_GeoCoordTest.php
b/tests/phpunit/includes/dataitems/DI_GeoCoordTest.php
index 07a4950..6683624 100644
--- a/tests/phpunit/includes/dataitems/DI_GeoCoordTest.php
+++ b/tests/phpunit/includes/dataitems/DI_GeoCoordTest.php
@@ -5,7 +5,6 @@
/**
* @covers SMWDIGeoCoord
* @covers SMWDataItem
- * Tests for the SMWDIGeoCoord class.
*
* @file
* @since 1.8
diff --git a/tests/phpunit/includes/dataitems/DI_NumberTest.php
b/tests/phpunit/includes/dataitems/DI_NumberTest.php
index e20b323..f2e0825 100644
--- a/tests/phpunit/includes/dataitems/DI_NumberTest.php
+++ b/tests/phpunit/includes/dataitems/DI_NumberTest.php
@@ -5,7 +5,6 @@
/**
* @covers SMWDINumber
* @covers SMWDataItem
- * Tests for the SMWDINumber class.
*
* @file
* @since 1.8
diff --git a/tests/phpunit/includes/dataitems/DataItemTest.php
b/tests/phpunit/includes/dataitems/DataItemTest.php
index d8428f8..1eea6eb 100644
--- a/tests/phpunit/includes/dataitems/DataItemTest.php
+++ b/tests/phpunit/includes/dataitems/DataItemTest.php
@@ -2,6 +2,8 @@
namespace SMW\Tests;
+use SMWDataItem;
+
/**
* Base class for SMW\DataItem tests.
*
@@ -121,4 +123,18 @@
);
}
+ /**
+ * @dataProvider instanceProvider
+ */
+ public function testInstanceEqualsItself( SMWDataItem $di ) {
+ $this->assertTrue( $di->equals( $di ) );
+ }
+
+ /**
+ * @dataProvider instanceProvider
+ */
+ public function testInstanceDoesNotEqualNyanData( SMWDataItem $di ) {
+ $this->assertFalse( $di->equals( new \SMWDIBlob( '~=[,,_,,]:3'
) ) );
+ }
+
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/86426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I260f2383d2db915a4aa349cdf26ada9eb511744f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
