Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86713
Change subject: Beta: Open sections by default in tablet view
......................................................................
Beta: Open sections by default in tablet view
Change-Id: I507b0cf9faca49bcb4a92bb45cf7dd68874487e1
---
M javascripts/common/application.js
M javascripts/modules/mf-toggle.js
M javascripts/modules/search/pageImages.js
3 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/13/86713/1
diff --git a/javascripts/common/application.js
b/javascripts/common/application.js
index de06fd2..8250a60 100644
--- a/javascripts/common/application.js
+++ b/javascripts/common/application.js
@@ -270,6 +270,10 @@
document.title = page.title;
}
+ function isTabletView() {
+ return window.innerWidth > 768;
+ }
+
$( init );
$.extend( M, {
@@ -281,6 +285,7 @@
return $( '#content div' ).eq( 0 );
},
getSessionId: getSessionId,
+ isTabletView: isTabletView,
isLoggedIn: isLoggedIn,
lockViewport: lockViewport,
log: log,
diff --git a/javascripts/modules/mf-toggle.js b/javascripts/modules/mf-toggle.js
index 2f93781..39c2ffd 100644
--- a/javascripts/modules/mf-toggle.js
+++ b/javascripts/modules/mf-toggle.js
@@ -36,13 +36,19 @@
}
function init() {
- var $page = $( '#content' ), tagName = 'h2';
+ var $page = $( '#content' ), tagName = 'h2', openClassName = '';
+
+ // in beta expand all sections by default
+ if ( M.isTabletView() && mw.config.get( 'wgMFMode' ) !==
'stable' ) {
+ openClassName += ' openSection';
+ }
+
$( 'html' ).removeClass( 'stub' );
if ( $page.find( 'h1' ).length > 0 ) {
tagName = 'h1';
}
- $page.find( tagName ).addClass( 'section_heading' );
- $page.find( '.section_heading' ).next( 'div' ).addClass(
'content_block' );
+ $page.find( tagName ).addClass( 'section_heading' +
openClassName );
+ $page.find( '.section_heading' ).next( 'div' ).addClass(
'content_block' + openClassName );
// use mouseup because mousedown blocks the click event and
links
// in headings won't work
diff --git a/javascripts/modules/search/pageImages.js
b/javascripts/modules/search/pageImages.js
index c0acbae..d6b7ccd 100644
--- a/javascripts/modules/search/pageImages.js
+++ b/javascripts/modules/search/pageImages.js
@@ -2,7 +2,7 @@
var Api = M.require( 'api' ).Api,
// impose a 1 second delay for smaller devices to minimise data
charges
- delay = window.innerWidth > 768 ? 0 : 1000,
+ delay = M.isTabletView() ? 0 : 1000,
PageImageApi = Api.extend( {
getPageImages: function( titles ) {
var result = $.Deferred();
--
To view, visit https://gerrit.wikimedia.org/r/86713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I507b0cf9faca49bcb4a92bb45cf7dd68874487e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
