jenkins-bot has submitted this change and it was merged.
Change subject: Regression: Don't close drawers when tapping on them
......................................................................
Regression: Don't close drawers when tapping on them
Currently in alpha you can't click Login or Sign Up because the drawer
closes before the click event is fired.
Change-Id: I3cbb71e40256b69487e6aa1ae3988871972cf4df
---
M javascripts/common/Drawer.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/common/Drawer.js b/javascripts/common/Drawer.js
index 739702c..88745ae 100644
--- a/javascripts/common/Drawer.js
+++ b/javascripts/common/Drawer.js
@@ -31,7 +31,9 @@
setTimeout( function() {
$( window ).one(
'scroll.drawer', $.proxy( self, 'hide' ) );
// FIXME change when
micro.tap.js in stable
- $( 'body' ).one(
M.tapEvent( 'click' ) + '.drawer', $.proxy( self, 'hide' ) );
+ // can't use 'body'
because the drawer will be closed when
+ // tapping on it and
clicks will be prevented
+ $( '#mw-mf-page-center,
.mw-mf-overlay' ).one( M.tapEvent( 'click' ) + '.drawer', $.proxy( self, 'hide'
) );
}, self.minHideDelay );
}
}, 10 );
@@ -47,7 +49,7 @@
// .one() registers one callback for scroll and
click independently
// if one fired, get rid of the other one
$( window ).off( '.drawer' );
- $( 'body' ).off( '.drawer' );
+ $( '#mw-mf-page-center, .mw-mf-overlay' ).off(
'.drawer' );
}, 10 );
},
--
To view, visit https://gerrit.wikimedia.org/r/86723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cbb71e40256b69487e6aa1ae3988871972cf4df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
