MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86794
Change subject: jshint fixes for mw.UploadWizardUtil.js
......................................................................
jshint fixes for mw.UploadWizardUtil.js
Bug: 47161
Change-Id: I7009ef80c9708b2da235d46338516415d5cacc36
---
M resources/mw.UploadWizardUtil.js
1 file changed, 18 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/94/86794/1
diff --git a/resources/mw.UploadWizardUtil.js b/resources/mw.UploadWizardUtil.js
index b381ac0..fba14ce 100644
--- a/resources/mw.UploadWizardUtil.js
+++ b/resources/mw.UploadWizardUtil.js
@@ -13,31 +13,32 @@
* (with mwe-upwiz- prefix for UploadWizard messages)
*/
makeToggler: function ( toggleDiv, moreDiv, msg ) {
- var actualMsg;
+ function toggle() {
+ var isOpen = $toggleLink.hasClass(
'mwe-upwiz-toggler-open' );
+ if ( isOpen ) {
+ // hide the extra options
+ moreDiv.slideUp( 250 );
+ /* when closed, show control to open */
+ $toggleLink.removeClass(
'mwe-upwiz-toggler-open' );
+ } else {
+ // show the extra options
+ moreDiv.slideDown( 250 );
+ /* when open, show control to close */
+ $toggleLink.addClass( 'mwe-upwiz-toggler-open'
);
+ }
+ }
+
+ var $toggleLink, actualMsg;
+
if ( typeof msg === 'object' ) {
actualMsg = mw.message.apply( this, msg ).text();
} else {
actualMsg = mw.message( msg ).text();
}
- var $toggleLink = $( '<a>' )
+ $toggleLink = $( '<a>' )
.addClass( 'mwe-upwiz-toggler mwe-upwiz-more-options' )
.text( actualMsg );
$( toggleDiv ).append( $toggleLink );
-
- var toggle = function() {
- var isOpen = $toggleLink.hasClass(
"mwe-upwiz-toggler-open" );
- if ( isOpen ) {
- // hide the extra options
- moreDiv.slideUp( 250 );
- /* when closed, show control to open */
- $toggleLink.removeClass(
"mwe-upwiz-toggler-open" );
- } else {
- // show the extra options
- moreDiv.slideDown( 250 );
- /* when open, show control to close */
- $toggleLink.addClass( "mwe-upwiz-toggler-open"
);
- }
- };
moreDiv.hide();
--
To view, visit https://gerrit.wikimedia.org/r/86794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7009ef80c9708b2da235d46338516415d5cacc36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
