jenkins-bot has submitted this change and it was merged.
Change subject: Regression: Banners above chrome make hamburger and echo
disappear
......................................................................
Regression: Banners above chrome make hamburger and echo disappear
.header needs position: relative, it's not always at the top of the
page.
Change-Id: I2f0c84570cf9cdcb0b7626239007d0af1a79f693
---
M less/common/ui.less
M stylesheets/common/ui.css
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/less/common/ui.less b/less/common/ui.less
index ae0a6ac..16481d8 100644
--- a/less/common/ui.less
+++ b/less/common/ui.less
@@ -2,6 +2,9 @@
@import 'mainmenu.less';
.header {
+ // .header needs position: relative, it's not always at the top of the
page
+ // (Zero banners, campaigns)
+ position: relative;
.vertical-gradient( @searchBoxColor, @searchBoxColorTo );
border-bottom: 1px solid #e2e2e2;
line-height: @headerHeight;
diff --git a/stylesheets/common/ui.css b/stylesheets/common/ui.css
index 03a7372..b29bc78 100644
--- a/stylesheets/common/ui.css
+++ b/stylesheets/common/ui.css
@@ -341,6 +341,7 @@
}
}
.header {
+ position: relative;
background-color: #f3f3f3;
background-image: -moz-linear-gradient(top, #fafafa 0, #f3f3f3 100%);
background-image: -webkit-gradient(linear, left top, left bottom,
color-stop(0, #fafafa), color-stop(100%, #f3f3f3));
--
To view, visit https://gerrit.wikimedia.org/r/87012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f0c84570cf9cdcb0b7626239007d0af1a79f693
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
