Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/87061
Change subject: General cleanup of API related code ...................................................................... General cleanup of API related code Change-Id: Icb7099e428898083f899039429d1e9e41b114cfb --- M repo/includes/api/ApiWikibase.php M repo/includes/api/ModifyEntity.php M repo/includes/api/RemoveQualifiers.php M repo/includes/api/RemoveReferences.php M repo/includes/api/SetAliases.php M repo/includes/api/SetClaimValue.php M repo/includes/api/SetDescription.php M repo/includes/api/SetLabel.php M repo/includes/api/SetSiteLink.php M repo/includes/api/SetStatementRank.php M repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php M repo/tests/phpunit/includes/api/SetReferenceTest.php M repo/tests/phpunit/includes/api/SnakValidationHelperTest.php 13 files changed, 2 insertions(+), 92 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/61/87061/1 diff --git a/repo/includes/api/ApiWikibase.php b/repo/includes/api/ApiWikibase.php index 214426a..32b3a20 100644 --- a/repo/includes/api/ApiWikibase.php +++ b/repo/includes/api/ApiWikibase.php @@ -5,12 +5,10 @@ use User, Status, ApiBase; use Wikibase\Claims; use Wikibase\DataModel\SimpleSiteLink; -use Wikibase\Entity; use Wikibase\EntityContent; use Wikibase\Lib\Serializers\ClaimsSerializer; use Wikibase\Settings; use Wikibase\EditEntity; -use Wikibase\SiteLink; use Wikibase\Repo\WikibaseRepo; use Wikibase\Lib\Serializers\LabelSerializer; use Wikibase\Lib\Serializers\DescriptionSerializer; diff --git a/repo/includes/api/ModifyEntity.php b/repo/includes/api/ModifyEntity.php index ce17af9..f4cfe88 100644 --- a/repo/includes/api/ModifyEntity.php +++ b/repo/includes/api/ModifyEntity.php @@ -2,11 +2,8 @@ namespace Wikibase\Api; -use Status; -use User; -use Title; +use Status, User, Title; use ApiBase; -use Wikibase\Entity; use Wikibase\EntityContent; use Wikibase\EntityContentFactory; use Wikibase\ItemHandler; diff --git a/repo/includes/api/RemoveQualifiers.php b/repo/includes/api/RemoveQualifiers.php index 7c5604b..f5ed9d3 100644 --- a/repo/includes/api/RemoveQualifiers.php +++ b/repo/includes/api/RemoveQualifiers.php @@ -3,7 +3,6 @@ namespace Wikibase\Api; use ApiBase; -use Wikibase\Entity; use Wikibase\Claim; use Wikibase\Repo\WikibaseRepo; use Wikibase\ChangeOpQualifier; @@ -13,25 +12,7 @@ /** * API module for removing qualifiers from a claim. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.3 - * - * @ingroup WikibaseRepo - * @ingroup API * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/repo/includes/api/RemoveReferences.php b/repo/includes/api/RemoveReferences.php index 3410f66..e2210eb 100644 --- a/repo/includes/api/RemoveReferences.php +++ b/repo/includes/api/RemoveReferences.php @@ -3,7 +3,6 @@ namespace Wikibase\Api; use ApiBase; -use Wikibase\Entity; use Wikibase\Statement; use Wikibase\Repo\WikibaseRepo; use Wikibase\ChangeOpReference; @@ -13,25 +12,7 @@ /** * API module for removing one or more references of the same statement. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.3 - * - * @ingroup WikibaseRepo - * @ingroup API * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/repo/includes/api/SetAliases.php b/repo/includes/api/SetAliases.php index 76e7080..9e86a89 100644 --- a/repo/includes/api/SetAliases.php +++ b/repo/includes/api/SetAliases.php @@ -4,7 +4,6 @@ use Wikibase\ChangeOps; use ApiBase, User, Language; -use Wikibase\Entity; use Wikibase\EntityContent; use Wikibase\Utils; use Wikibase\ChangeOpAliases; diff --git a/repo/includes/api/SetClaimValue.php b/repo/includes/api/SetClaimValue.php index 3cf64be..3fa43b3 100644 --- a/repo/includes/api/SetClaimValue.php +++ b/repo/includes/api/SetClaimValue.php @@ -3,7 +3,6 @@ namespace Wikibase\Api; use ApiBase; -use Wikibase\Entity; use Wikibase\ChangeOpMainSnak; use Wikibase\ChangeOpException; use Wikibase\Lib\ClaimGuidGenerator; diff --git a/repo/includes/api/SetDescription.php b/repo/includes/api/SetDescription.php index 3b9da9a..4c63be9 100644 --- a/repo/includes/api/SetDescription.php +++ b/repo/includes/api/SetDescription.php @@ -3,7 +3,6 @@ namespace Wikibase\Api; use ApiBase; -use Wikibase\Entity; use Wikibase\EntityContent; use Wikibase\Utils; use Wikibase\ChangeOpDescription; diff --git a/repo/includes/api/SetLabel.php b/repo/includes/api/SetLabel.php index 2e113fa..354f1b5 100644 --- a/repo/includes/api/SetLabel.php +++ b/repo/includes/api/SetLabel.php @@ -3,7 +3,6 @@ namespace Wikibase\Api; use ApiBase; -use Wikibase\Entity; use Wikibase\EntityContent; use Wikibase\Utils; use Wikibase\ChangeOpLabel; diff --git a/repo/includes/api/SetSiteLink.php b/repo/includes/api/SetSiteLink.php index f9dd159..79a23a2 100644 --- a/repo/includes/api/SetSiteLink.php +++ b/repo/includes/api/SetSiteLink.php @@ -4,7 +4,6 @@ use Wikibase\ChangeOpSiteLink; use ApiBase, User; -use Wikibase\Entity; use Wikibase\EntityContent; use Wikibase\ItemContent; use Wikibase\Utils; diff --git a/repo/includes/api/SetStatementRank.php b/repo/includes/api/SetStatementRank.php index b5d5d21..7d592a1 100644 --- a/repo/includes/api/SetStatementRank.php +++ b/repo/includes/api/SetStatementRank.php @@ -3,7 +3,6 @@ namespace Wikibase\Api; use ApiBase; -use Wikibase\Entity; use Wikibase\Claim; use Wikibase\Repo\WikibaseRepo; use Wikibase\ChangeOpStatementRank; @@ -14,25 +13,7 @@ /** * API module for setting the rank of a statement * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.3 - * - * @ingroup WikibaseRepo - * @ingroup API * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php b/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php index c3b3b00..73362b0 100644 --- a/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php +++ b/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php @@ -5,31 +5,12 @@ use Wikibase\EntityId; use Wikibase\Item; use Wikibase\Repo\WikibaseRepo; -use Wikibase\Settings; use Wikibase\StringNormalizer; /** * Tests for the ItemByTitleHelper api helper class. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * - * @file * @since 0.4 - * - * @ingroup Test * * @licence GNU GPL v2+ * @author Marius Hoch < [email protected] > diff --git a/repo/tests/phpunit/includes/api/SetReferenceTest.php b/repo/tests/phpunit/includes/api/SetReferenceTest.php index e6dcf18..9c00b76 100644 --- a/repo/tests/phpunit/includes/api/SetReferenceTest.php +++ b/repo/tests/phpunit/includes/api/SetReferenceTest.php @@ -1,9 +1,9 @@ <?php namespace Wikibase\Test\Api; + use Wikibase\PropertyContent; use Wikibase\Reference; -use Wikibase\Statement; /** * Unit tests for the Wikibase\ApiSetReference class. diff --git a/repo/tests/phpunit/includes/api/SnakValidationHelperTest.php b/repo/tests/phpunit/includes/api/SnakValidationHelperTest.php index a8ae52f..181227e 100644 --- a/repo/tests/phpunit/includes/api/SnakValidationHelperTest.php +++ b/repo/tests/phpunit/includes/api/SnakValidationHelperTest.php @@ -4,9 +4,7 @@ use DataTypes\DataType; use DataTypes\DataTypeFactory; -use DataValues\DataValue; use DataValues\StringValue; -use ValueValidators\StringValidator; use Wikibase\Claim; use Wikibase\EntityId; use Wikibase\Lib\InMemoryDataTypeLookup; @@ -17,11 +15,9 @@ use Wikibase\PropertyValueSnak; use Wikibase\Reference; use Wikibase\ReferenceList; -use Wikibase\References; use Wikibase\Snak; use Wikibase\SnakList; use Wikibase\Statement; -use Wikibase\Validators\DataValueValidator; use Wikibase\Validators\SnakValidator; /** -- To view, visit https://gerrit.wikimedia.org/r/87061 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb7099e428898083f899039429d1e9e41b114cfb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Addshore <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
