Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/87066


Change subject: Cleanup of ChangeOp related code
......................................................................

Cleanup of ChangeOp related code

Change-Id: I858c794f6e548e70bfab54bf3e236f654e1ecd41
---
M repo/includes/changeop/ChangeOp.php
M repo/includes/changeop/ChangeOpAliases.php
M repo/includes/changeop/ChangeOpBase.php
M repo/includes/changeop/ChangeOpClaim.php
M repo/includes/changeop/ChangeOpDescription.php
M repo/includes/changeop/ChangeOpException.php
M repo/includes/changeop/ChangeOpLabel.php
M repo/includes/changeop/ChangeOpMainSnak.php
M repo/includes/changeop/ChangeOpQualifier.php
M repo/includes/changeop/ChangeOpReference.php
M repo/includes/changeop/ChangeOpSiteLink.php
M repo/includes/changeop/ChangeOpStatementRank.php
M repo/includes/changeop/ChangeOps.php
M repo/tests/phpunit/includes/changeop/ChangeOpAliasesTest.php
M repo/tests/phpunit/includes/changeop/ChangeOpDescriptionTest.php
M repo/tests/phpunit/includes/changeop/ChangeOpLabelTest.php
M repo/tests/phpunit/includes/changeop/ChangeOpMainSnakTest.php
M repo/tests/phpunit/includes/changeop/ChangeOpSiteLinkTest.php
M repo/tests/phpunit/includes/changeop/ChangeOpsTest.php
19 files changed, 20 insertions(+), 270 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/66/87066/1

diff --git a/repo/includes/changeop/ChangeOp.php 
b/repo/includes/changeop/ChangeOp.php
index a38e46d..713cb5e 100644
--- a/repo/includes/changeop/ChangeOp.php
+++ b/repo/includes/changeop/ChangeOp.php
@@ -1,7 +1,6 @@
 <?php
 
 namespace Wikibase;
-use InvalidArgumentException;
 
 /**
  * @since 0.5
diff --git a/repo/includes/changeop/ChangeOpAliases.php 
b/repo/includes/changeop/ChangeOpAliases.php
index 4f3ae2b..5b260bc 100644
--- a/repo/includes/changeop/ChangeOpAliases.php
+++ b/repo/includes/changeop/ChangeOpAliases.php
@@ -7,25 +7,7 @@
 /**
  * Class for aliases change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpBase.php 
b/repo/includes/changeop/ChangeOpBase.php
index 210d079..f7f009d 100644
--- a/repo/includes/changeop/ChangeOpBase.php
+++ b/repo/includes/changeop/ChangeOpBase.php
@@ -8,7 +8,6 @@
  * Base class for change operations.
  *
  * @since 0.4
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpClaim.php 
b/repo/includes/changeop/ChangeOpClaim.php
index af21f24..36c9698 100644
--- a/repo/includes/changeop/ChangeOpClaim.php
+++ b/repo/includes/changeop/ChangeOpClaim.php
@@ -8,6 +8,7 @@
 
 /**
  * Class for claim modification operations
+ *
  * @since 0.4
  * @licence GNU GPL v2+
  * @author Adam Shorland
diff --git a/repo/includes/changeop/ChangeOpDescription.php 
b/repo/includes/changeop/ChangeOpDescription.php
index 83d89aa..6d609e6 100644
--- a/repo/includes/changeop/ChangeOpDescription.php
+++ b/repo/includes/changeop/ChangeOpDescription.php
@@ -7,25 +7,7 @@
 /**
  * Class for description change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpException.php 
b/repo/includes/changeop/ChangeOpException.php
index b945447..d0e547b 100644
--- a/repo/includes/changeop/ChangeOpException.php
+++ b/repo/includes/changeop/ChangeOpException.php
@@ -5,26 +5,7 @@
 /**
  * Exception thrown during an invalid change operation.
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @file
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpLabel.php 
b/repo/includes/changeop/ChangeOpLabel.php
index 3c1ee13..4864575 100644
--- a/repo/includes/changeop/ChangeOpLabel.php
+++ b/repo/includes/changeop/ChangeOpLabel.php
@@ -7,25 +7,7 @@
 /**
  * Class for label change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpMainSnak.php 
b/repo/includes/changeop/ChangeOpMainSnak.php
index bbc2a25..accb42b 100644
--- a/repo/includes/changeop/ChangeOpMainSnak.php
+++ b/repo/includes/changeop/ChangeOpMainSnak.php
@@ -11,7 +11,6 @@
  * Class for mainsnak change operation
  *
  * @since 0.4
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpQualifier.php 
b/repo/includes/changeop/ChangeOpQualifier.php
index 86b6f6b..7856fd1 100644
--- a/repo/includes/changeop/ChangeOpQualifier.php
+++ b/repo/includes/changeop/ChangeOpQualifier.php
@@ -10,25 +10,7 @@
 /**
  * Class for qualifier change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpReference.php 
b/repo/includes/changeop/ChangeOpReference.php
index b56df8e..c48eeb8 100644
--- a/repo/includes/changeop/ChangeOpReference.php
+++ b/repo/includes/changeop/ChangeOpReference.php
@@ -12,25 +12,7 @@
 /**
  * Class for reference change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
@@ -72,9 +54,9 @@
         * @param string $claimGuid
         * @param Reference|null $reference
         * @param string $referenceHash
-        * @param EntityIdFormatter $entityIdFormatter
+        * @param Lib\EntityIdFormatter $idFormatter
         *
-        * @throws InvalidArgumentException
+        * @throws \InvalidArgumentException
         */
        public function __construct( $claimGuid, $reference, $referenceHash, 
EntityIdFormatter $idFormatter ) {
                if ( !is_string( $claimGuid ) || $claimGuid === '' ) {
@@ -200,8 +182,7 @@
        /**
         * @since 0.4
         *
-        * @param Reference $reference
-        *
+        * @param Snak $snak
         * @return array
         *
         * @todo: REUSE!!
diff --git a/repo/includes/changeop/ChangeOpSiteLink.php 
b/repo/includes/changeop/ChangeOpSiteLink.php
index a7b0756..df16f63 100644
--- a/repo/includes/changeop/ChangeOpSiteLink.php
+++ b/repo/includes/changeop/ChangeOpSiteLink.php
@@ -2,32 +2,14 @@
 
 namespace Wikibase;
 
-use InvalidArgumentException;
 use Site;
+use InvalidArgumentException;
 use Wikibase\DataModel\SimpleSiteLink;
 
 /**
  * Class for sitelink change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/includes/changeop/ChangeOpStatementRank.php 
b/repo/includes/changeop/ChangeOpStatementRank.php
index 75527ff..a03bb68 100644
--- a/repo/includes/changeop/ChangeOpStatementRank.php
+++ b/repo/includes/changeop/ChangeOpStatementRank.php
@@ -11,25 +11,7 @@
 /**
  * Class for statement rank change operation
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
@@ -63,9 +45,9 @@
         *
         * @param string $claimGuid
         * @param integer $rank
-        * @param EntityIdFormatter $entityIdFormatter
+        * @param Lib\EntityIdFormatter $idFormatter
         *
-        * @throws InvalidArgumentException
+        * @throws \InvalidArgumentException
         */
        public function __construct( $claimGuid, $rank, EntityIdFormatter 
$idFormatter ) {
                if ( !is_string( $claimGuid ) ) {
@@ -115,7 +97,7 @@
        /**
         * @since 0.4
         *
-        * @param Snak $mainSnak
+        * @param Snak $snak
         *
         * @return array
         *
diff --git a/repo/includes/changeop/ChangeOps.php 
b/repo/includes/changeop/ChangeOps.php
index 79ebc4a..f932763 100644
--- a/repo/includes/changeop/ChangeOps.php
+++ b/repo/includes/changeop/ChangeOps.php
@@ -7,25 +7,7 @@
 /**
  * Class for holding a batch of change operations
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
  * @since 0.4
- *
- * @ingroup WikibaseRepo
- *
  * @licence GNU GPL v2+
  * @author Tobias Gritschacher < [email protected] >
  */
diff --git a/repo/tests/phpunit/includes/changeop/ChangeOpAliasesTest.php 
b/repo/tests/phpunit/includes/changeop/ChangeOpAliasesTest.php
index 1304ec0..dd55ee5 100644
--- a/repo/tests/phpunit/includes/changeop/ChangeOpAliasesTest.php
+++ b/repo/tests/phpunit/includes/changeop/ChangeOpAliasesTest.php
@@ -3,31 +3,14 @@
 namespace Wikibase\Test;
 
 use Wikibase\ChangeOpAliases;
+use Wikibase\Entity;
 use Wikibase\ItemContent;
 use InvalidArgumentException;
 
 /**
  * @covers Wikibase\ChangeOpAliases
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
USA
- *
- * @file
  * @since 0.4
- *
- * @ingroup Wikibase
- * @ingroup Test
  *
  * @group Wikibase
  * @group WikibaseRepo
@@ -87,7 +70,7 @@
        }
 
        /**
-        * @expectedException Wikibase\ChangeOpException
+        * @expectedException  \Wikibase\ChangeOpException
         */
        public function testApplyWithInvalidAction() {
                $item = ItemContent::newEmpty();
diff --git a/repo/tests/phpunit/includes/changeop/ChangeOpDescriptionTest.php 
b/repo/tests/phpunit/includes/changeop/ChangeOpDescriptionTest.php
index b12d2d1..db62301 100644
--- a/repo/tests/phpunit/includes/changeop/ChangeOpDescriptionTest.php
+++ b/repo/tests/phpunit/includes/changeop/ChangeOpDescriptionTest.php
@@ -2,6 +2,7 @@
 
 namespace Wikibase\Test;
 
+use Wikibase\ChangeOp;
 use Wikibase\ChangeOpDescription;
 use Wikibase\ItemContent;
 use InvalidArgumentException;
@@ -10,25 +11,7 @@
 /**
  * @covers Wikibase\ChangeOpDescription
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
USA
- *
- * @file
  * @since 0.4
- *
- * @ingroup Wikibase
- * @ingroup Test
  *
  * @group Wikibase
  * @group WikibaseRepo
@@ -95,7 +78,7 @@
        /**
         * @dataProvider changeOpSummaryProvider
         */
-       public function testUpdateSummary( $entity, $changeOp, 
$summaryExpectedAction, $summaryExpectedLanguage ) {
+       public function testUpdateSummary( $entity, ChangeOp $changeOp, 
$summaryExpectedAction, $summaryExpectedLanguage ) {
                $summary = new Summary();
 
                $changeOp->apply( $entity, $summary );
diff --git a/repo/tests/phpunit/includes/changeop/ChangeOpLabelTest.php 
b/repo/tests/phpunit/includes/changeop/ChangeOpLabelTest.php
index 1a1ff31..4a150e2 100644
--- a/repo/tests/phpunit/includes/changeop/ChangeOpLabelTest.php
+++ b/repo/tests/phpunit/includes/changeop/ChangeOpLabelTest.php
@@ -2,6 +2,7 @@
 
 namespace Wikibase\Test;
 
+use Wikibase\ChangeOp;
 use Wikibase\Summary;
 use Wikibase\ChangeOpLabel;
 use Wikibase\ItemContent;
@@ -10,25 +11,7 @@
 /**
  * @covers Wikibase\ChangeOpLabel
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
USA
- *
- * @file
  * @since 0.4
- *
- * @ingroup Wikibase
- * @ingroup Test
  *
  * @group Wikibase
  * @group WikibaseRepo
@@ -95,7 +78,7 @@
        /**
         * @dataProvider changeOpSummaryProvider
         */
-       public function testUpdateSummary( $entity, $changeOp, 
$summaryExpectedAction, $summaryExpectedLanguage ) {
+       public function testUpdateSummary( $entity, ChangeOp $changeOp, 
$summaryExpectedAction, $summaryExpectedLanguage ) {
                $summary = new Summary();
 
                $changeOp->apply( $entity, $summary );
diff --git a/repo/tests/phpunit/includes/changeop/ChangeOpMainSnakTest.php 
b/repo/tests/phpunit/includes/changeop/ChangeOpMainSnakTest.php
index abc2b17..26cfeb4 100644
--- a/repo/tests/phpunit/includes/changeop/ChangeOpMainSnakTest.php
+++ b/repo/tests/phpunit/includes/changeop/ChangeOpMainSnakTest.php
@@ -3,6 +3,7 @@
 namespace Wikibase\Test;
 
 use DataValues\DataValue;
+use Wikibase\ChangeOp;
 use Wikibase\Claim;
 use Wikibase\Claims;
 use Wikibase\ChangeOpMainSnak;
@@ -121,7 +122,7 @@
         * @dataProvider provideChangeOps
         * @expectedException \Wikibase\ChangeOpException
         */
-       public function testInvalidApply( $changeOp ) {
+       public function testInvalidApply( ChangeOp $changeOp ) {
                $wrongItem = ItemContent::newEmpty();
                $changeOp->apply( $wrongItem->getEntity() );
        }
diff --git a/repo/tests/phpunit/includes/changeop/ChangeOpSiteLinkTest.php 
b/repo/tests/phpunit/includes/changeop/ChangeOpSiteLinkTest.php
index 544daa5..db158c7 100644
--- a/repo/tests/phpunit/includes/changeop/ChangeOpSiteLinkTest.php
+++ b/repo/tests/phpunit/includes/changeop/ChangeOpSiteLinkTest.php
@@ -12,25 +12,7 @@
 /**
  * @covers Wikibase\ChangeOpSiteLink
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
USA
- *
- * @file
  * @since 0.4
- *
- * @ingroup Wikibase
- * @ingroup Test
  *
  * @group Wikibase
  * @group WikibaseRepo
diff --git a/repo/tests/phpunit/includes/changeop/ChangeOpsTest.php 
b/repo/tests/phpunit/includes/changeop/ChangeOpsTest.php
index fd8145c..db8e59a 100644
--- a/repo/tests/phpunit/includes/changeop/ChangeOpsTest.php
+++ b/repo/tests/phpunit/includes/changeop/ChangeOpsTest.php
@@ -2,6 +2,8 @@
 
 namespace Wikibase\Test;
 
+use InvalidArgumentException;
+use Wikibase\ChangeOp;
 use Wikibase\ChangeOpLabel;
 use Wikibase\ChangeOpDescription;
 use Wikibase\ChangeOpAliases;
@@ -11,25 +13,7 @@
 /**
  * @covers Wikibase\ChangeOps
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, 
USA
- *
- * @file
  * @since 0.4
- *
- * @ingroup Wikibase
- * @ingroup Test
  *
  * @group Wikibase
  * @group WikibaseRepo
@@ -84,7 +68,7 @@
        /**
         * @dataProvider changeOpArrayProvider
         *
-        * @param ChangeOp[] $changeOp
+        * @param $changeOpArray
         */
        public function testAddArray( $changeOpArray ) {
                $changeOps = new ChangeOps();
@@ -141,7 +125,7 @@
        }
 
        /**
-        * @expectedException Wikibase\ChangeOpException
+        * @expectedException  \Wikibase\ChangeOpException
         */
        public function testInvalidApply() {
                $item = ItemContent::newEmpty();

-- 
To view, visit https://gerrit.wikimedia.org/r/87066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I858c794f6e548e70bfab54bf3e236f654e1ecd41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to