jenkins-bot has submitted this change and it was merged.
Change subject: Fix infobox styling on larger resolutions
......................................................................
Fix infobox styling on larger resolutions
* Fix overlap between headings and infobox on desktop
* Limit Infobox styling changes to beta rather
than everywhere
* Undo table display tweaks in tablet mode
Bug: 54895
Change-Id: I73f7c583758a854107a28b864a008e2ad466c124
---
M less/common/enwp.less
1 file changed, 31 insertions(+), 7 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/less/common/enwp.less b/less/common/enwp.less
index 87d6761..c9b44ec 100644
--- a/less/common/enwp.less
+++ b/less/common/enwp.less
@@ -127,13 +127,37 @@
/* Tablet specific styling */
@media all and (min-width: 768px) {
- // FIXME [Templates]: Inline styles force us to use !important
- table.infobox {
- max-width: 400px;
- width: auto !important;
- float: right !important;
- margin-left: @contentMarginRight !important;
- clear: right !important;
+ .beta #content_wrapper {
+ @infoboxWidth: 400px;
+
+ .section_heading,
+ .content_block {
+ margin-right: @infoboxWidth + 16;
+ }
+
+ .content_block {
+ width: auto;
+ clear: none;
+ }
+
+ // Override rules in common.less
+ table {
+ display: table;
+ tbody {
+ display: table-row-group;
+ }
+ }
+
+ // Float infoboxes to the right of the page
+ table.infobox {
+ // Note this is fixed to ensure that we leave enough
space for the sections to the infoboxes left
+ max-width: @infoboxWidth;
+ // FIXME [Templates]: Inline styles force us to use
!important
+ width: auto !important;
+ float: right !important;
+ margin-left: @contentMarginRight !important;
+ clear: right !important;
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/86715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73f7c583758a854107a28b864a008e2ad466c124
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
