[MediaWiki-commits] [Gerrit] Add some limited scope to the special page - change (mediawiki...MassMessage)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/87528


Change subject: Add some limited scope to the special page
......................................................................

Add some limited scope to the special page

Change-Id: Ia3a5338a229815e97bab2baf3a197d6e3a5e8885
---
M SpecialMassMessage.php
1 file changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage 
refs/changes/28/87528/1

diff --git a/SpecialMassMessage.php b/SpecialMassMessage.php
index 8141463..b5045cb 100644
--- a/SpecialMassMessage.php
+++ b/SpecialMassMessage.php
@@ -28,11 +28,11 @@
         */
        protected $count;
 
-       function __construct() {
+       public function __construct() {
                parent::__construct( 'MassMessage', 'massmessage' );
        }
 
-       function execute( $par ) {
+       public function execute( $par ) {
                $request = $this->getRequest();
                $context = $this->getContext();
                $output = $this->getOutput();
@@ -82,14 +82,14 @@
        /**
         * @return string
         */
-       function getState() {
+       public function getState() {
                return $this->state;
        }
 
        /**
         * @return Status
         */
-       function getStatus() {
+       public function getStatus() {
                return $this->status;
        }
 
@@ -97,14 +97,14 @@
         * Note that this won't be initalized unless submit is called
         * @return int
         */
-       function getCount() {
+       public function getCount() {
                return $this->count;
        }
 
        /**
         * @return array
         */
-       function createForm() {
+       protected function createForm() {
                $request = $this->getRequest();
                $context = $this->getContext();
                $m = array();
@@ -155,7 +155,7 @@
         * @param $spamlist Title
         * @param $subject string
         */
-       function logToWiki( $spamlist, $subject ) {
+       protected function logToWiki( $spamlist, $subject ) {
                // $title->getLatestRevID()
 
                $logEntry = new ManualLogEntry( 'massmessage', 'send' );
@@ -176,7 +176,7 @@
         * @param $data Array
         * @return Status
         */
-       function callback( $data ) {
+       public function callback( $data ) {
 
                $this->verifyData( $data );
 
@@ -207,7 +207,7 @@
         * @param $title string
         * @return Title|string string will be a error message key
         */
-       function getSpamlist( $title ) {
+       protected function getSpamlist( $title ) {
                $spamlist = Title::newFromText( $title );
                if ( $spamlist === null || !$spamlist->exists() ) {
                        return 'massmessage-spamlist-doesnotexist';
@@ -230,7 +230,7 @@
         * @param $data Array
         * @return Status
         */
-       function verifyData( $data ) {
+       protected function verifyData( $data ) {
                // Trim all the things!
                foreach ( $data as $k => $v ) {
                        $data[$k] = trim( $v );
@@ -258,7 +258,7 @@
         * @param $data Array
         * @return Status
         */
-       function preview( $data ) {
+       protected function preview( $data ) {
                // $spamlist = $this->getSpamlist( $data['spamlist'] );
                // $targets = MassMessage::getParserFunctionTargets( $spamlist, 
$this->getContext() );
                // $firstTarget = array_values( $targets )[0]; // Why doesn't 
this work??
@@ -300,7 +300,7 @@
         * @param $data Array
         * @return Status
         */
-       function submit( $data ) {
+       protected function submit( $data ) {
                global $wgDBname;
                $spamlist = $this->getSpamlist( $data['spamlist'] );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/87528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3a5338a229815e97bab2baf3a197d6e3a5e8885
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits