ArielGlenn has submitted this change and it was merged.

Change subject: Use line (rather than stack) graph type for static assets
......................................................................


Use line (rather than stack) graph type for static assets

Siebrand pointed out that stacking doesn't make sense in this context, and I'm
inclined to agree.

Change-Id: I313c141f28c36efc3f9f8879a7e054364e2827e0
---
M manifests/misc/monitoring.pp
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  ArielGlenn: Looks good to me, approved
  Siebrand: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/manifests/misc/monitoring.pp b/manifests/misc/monitoring.pp
index a84d140..5e2938d 100644
--- a/manifests/misc/monitoring.pp
+++ b/manifests/misc/monitoring.pp
@@ -319,37 +319,31 @@
                 title        => 'Main page JavaScript byte payload',
                 host_regex   => 'client-side',
                 metric_regex => '^assets_javascript_bytes_*',
-                type         => 'stack',
             },
             {
                 title        => 'Main page JavaScript requests',
                 host_regex   => 'client-side',
                 metric_regex => '^assets_javascript_requests_*',
-                type         => 'stack',
             },
             {
                 title        => 'Main page CSS byte payload',
                 host_regex   => 'client-side',
                 metric_regex => '^assets_css_bytes_*',
-                type         => 'stack',
             },
             {
                 title        => 'Main page CSS requests',
                 host_regex   => 'client-side',
                 metric_regex => '^assets_css_requests_*',
-                type         => 'stack',
             },
             {
                 title        => 'Main page image byte payload',
                 host_regex   => 'client-side',
                 metric_regex => '^assets_image_bytes_*',
-                type         => 'stack',
             },
             {
                 title        => 'Main page image requests',
                 host_regex   => 'client-side',
                 metric_regex => '^assets_image_requests_*',
-                type         => 'stack',
             },
         ],
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/87521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I313c141f28c36efc3f9f8879a7e054364e2827e0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to