Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/87536


Change subject: Use '//'-style comments in LESS doc blocks
......................................................................

Use '//'-style comments in LESS doc blocks

lessphp strips '//' comments but (when you setPreserveComments is set -- which
we do) not '/* */' comments. This means we should continue using /* for @embed
/ @noflip so that they are preserved in the generated CSS that is passed on to
CSSJanus / CSSMin, but for large comment blocks we should use '//' instead.

Change-Id: I32095bac4ed210123611b8372ed1a764f5fc9695
---
M resources/mediawiki.less/mediawiki.mixins.less
1 file changed, 9 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/36/87536/1

diff --git a/resources/mediawiki.less/mediawiki.mixins.less 
b/resources/mediawiki.less/mediawiki.mixins.less
index 032028f..3315f86 100644
--- a/resources/mediawiki.less/mediawiki.mixins.less
+++ b/resources/mediawiki.less/mediawiki.mixins.less
@@ -1,14 +1,12 @@
-/**
- * Common LESS mixin library for MediaWiki
- *
- * By default the folder containing this file is included in 
$wgResourceLoaderLESSImportPaths,
- * which makes this file importable by all less files via '@import 
"mediawiki.mixins";'.
- *
- * The mixins included below are considered a public interface for MediaWiki 
extensions.
- * The signatures of parametrized mixins should be kept as stable as possible.
- *
- * See <http://lesscss.org/#-mixins> for more information about how to write 
mixins.
- */
+// Common LESS mixin library for MediaWiki
+//
+// By default the folder containing this file is included in 
$wgResourceLoaderLESSImportPaths,
+// which makes this file importable by all less files via '@import 
"mediawiki.mixins";'.
+//
+// The mixins included below are considered a public interface for MediaWiki 
extensions.
+// The signatures of parametrized mixins should be kept as stable as possible.
+//
+// See <http://lesscss.org/#-mixins> for more information about how to write 
mixins.
 
 .background-image(@url) when (embeddable(@url)) {
        background-image: embed(@url);

-- 
To view, visit https://gerrit.wikimedia.org/r/87536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32095bac4ed210123611b8372ed1a764f5fc9695
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to