Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/87568
Change subject: Remove TODOS about non existant global
......................................................................
Remove TODOS about non existant global
This global was already removed
this todo is Done!
Change-Id: Ie4defbc8b3d67fb315ee44aab3723c6e42b8af15
---
M src/MySQL/MySQLTableSqlBuilder.php
M src/SQLite/SQLiteTableSqlBuilder.php
2 files changed, 0 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase
refs/changes/68/87568/1
diff --git a/src/MySQL/MySQLTableSqlBuilder.php
b/src/MySQL/MySQLTableSqlBuilder.php
index c1ae2ab..75541fa 100644
--- a/src/MySQL/MySQLTableSqlBuilder.php
+++ b/src/MySQL/MySQLTableSqlBuilder.php
@@ -47,7 +47,6 @@
* @return string
*/
public function getCreateTableSql( TableDefinition $table ) {
- // TODO: get rid of global (DatabaseBase currently provides no
access to its mTablePrefix field)
$sql = 'CREATE TABLE `' . $this->dbName . '`.' .
$this->tableNameFormatter->formatTableName(
$table->getName() ) .' (';
diff --git a/src/SQLite/SQLiteTableSqlBuilder.php
b/src/SQLite/SQLiteTableSqlBuilder.php
index c190b1b..723ca7c 100644
--- a/src/SQLite/SQLiteTableSqlBuilder.php
+++ b/src/SQLite/SQLiteTableSqlBuilder.php
@@ -44,7 +44,6 @@
* @return string
*/
public function getCreateTableSql( TableDefinition $table ) {
- // TODO: get rid of global (DatabaseBase currently provides no
access to its mTablePrefix field)
$sql = 'CREATE TABLE ' .
$this->formatTableName( $table->getName() ) . ' (';
--
To view, visit https://gerrit.wikimedia.org/r/87568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4defbc8b3d67fb315ee44aab3723c6e42b8af15
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
