Milimetric has uploaded a new change for review.
https://gerrit.wikimedia.org/r/87596
Change subject: cleanup of flake8 problems
......................................................................
cleanup of flake8 problems
Change-Id: Ica8ce03da7d85148cf4aa7cba671182974271f64
---
M tests/test_metrics/test_survivors.py
1 file changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/96/87596/1
diff --git a/tests/test_metrics/test_survivors.py
b/tests/test_metrics/test_survivors.py
index 3bb217e..5685ca9 100644
--- a/tests/test_metrics/test_survivors.py
+++ b/tests/test_metrics/test_survivors.py
@@ -5,10 +5,9 @@
from tests.fixtures import DatabaseWithSurvivorCohortTest
from wikimetrics.metrics import Survivors
from wikimetrics.models import (
- Cohort, MetricReport, WikiUser, CohortWikiUser, MediawikiUser,
- Revision
+ Cohort, MetricReport, WikiUser, CohortWikiUser, MediawikiUser,
+ Revision,
)
-
class SurvivorsTest(DatabaseWithSurvivorCohortTest):
@@ -93,17 +92,25 @@
# NOTE: setting sunset_in_hours 10000 days in the future
# This means that in 82 years, this test will break
- andrew_user =
self.mwSession.query(MediawikiUser).filter(MediawikiUser.user_id ==
self.mw_andrew_id).first()
- andrew_revs = self.mwSession.query(Revision).join(MediawikiUser) \
- .filter(MediawikiUser.user_id==self.mw_andrew_id) \
- .order_by(Revision.rev_timestamp) \
- .all()
+ andrew_user = self.mwSession.query(MediawikiUser) \
+ .filter(MediawikiUser.user_id == self.mw_andrew_id) \
+ .first()
+ andrew_revs = self.mwSession.query(Revision) \
+ .join(MediawikiUser) \
+ .filter(MediawikiUser.user_id == self.mw_andrew_id) \
+ .order_by(Revision.rev_timestamp) \
+ .all()
m = Survivors(
namespaces=[self.survivors_namespace],
number_of_edits=2,
- survival_hours=int(((andrew_revs[2].rev_timestamp -
andrew_user.user_registration).total_seconds())/(3600)),
- sunset_in_hours=2*48
+ survival_hours=int(
+ ((andrew_revs[2].rev_timestamp - andrew_user.user_registration)
+ .total_seconds())
+ /
+ (3600)
+ ),
+ sunset_in_hours=2 * 48
)
results = m(list(self.cohort), self.mwSession)
--
To view, visit https://gerrit.wikimedia.org/r/87596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica8ce03da7d85148cf4aa7cba671182974271f64
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
