Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/87606
Change subject: Include information about backend cache hits/misses in XPP
header
......................................................................
Include information about backend cache hits/misses in XPP header
Follow-up to I1d7fd94f2, removing incorrect & badly named 'selser-cache-hit'
property in favor of 'backend-cache-hit'.
Change-Id: I7faea3df52d67c7088c3b35e0bf4cf83b3f15423
---
M js/lib/mediawiki.ApiRequest.js
M js/lib/mediawiki.SelectiveSerializer.js
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/06/87606/1
diff --git a/js/lib/mediawiki.ApiRequest.js b/js/lib/mediawiki.ApiRequest.js
index 0f8f37d..7669cbf 100644
--- a/js/lib/mediawiki.ApiRequest.js
+++ b/js/lib/mediawiki.ApiRequest.js
@@ -563,7 +563,11 @@
// Start the request
- this.request( this.requestOptions, this._requestCB.bind(this) );
+ this.request( this.requestOptions, this._requestCB.bind(this) ).on(
'end', function () {
+ if ( this.response && this.response.headers ) {
+ env.performance['backend-cache-hit'] = /hit/i.test(
hdrs['x-cache'] );
+ }
+ } );
}
// Inherit from ApiRequest
diff --git a/js/lib/mediawiki.SelectiveSerializer.js
b/js/lib/mediawiki.SelectiveSerializer.js
index 693669d..005d47d 100644
--- a/js/lib/mediawiki.SelectiveSerializer.js
+++ b/js/lib/mediawiki.SelectiveSerializer.js
@@ -180,7 +180,6 @@
console.error('Error
while fetching page source or original DOM!');
} else {
// no error.
-
self.env.performance['selser-cache-hit'] = true;
// Set the page source.
self.env.setPageSrcInfo(results[0]);
--
To view, visit https://gerrit.wikimedia.org/r/87606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7faea3df52d67c7088c3b35e0bf4cf83b3f15423
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
