Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/87612
Change subject: Remove placeholder tests
......................................................................
Remove placeholder tests
They give a false sense of test coverage and nobody's shown any
interest in implementing them.
Change-Id: Id15ddb555e059bb6a76c69ca57d09c91e96e91ce
---
M tests/phpunit/includes/api/ApiEditPageTest.php
M tests/phpunit/includes/api/ApiWatchTest.php
2 files changed, 0 insertions(+), 27 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/12/87612/1
diff --git a/tests/phpunit/includes/api/ApiEditPageTest.php
b/tests/phpunit/includes/api/ApiEditPageTest.php
index e680af6..b0efd19 100644
--- a/tests/phpunit/includes/api/ApiEditPageTest.php
+++ b/tests/phpunit/includes/api/ApiEditPageTest.php
@@ -193,10 +193,6 @@
$this->assertEquals( $expected, $text );
}
- function testEditSection() {
- $this->markTestIncomplete( "not yet implemented" );
- }
-
/**
* Test action=edit§ion=new
* Run it twice so we test adding a new section on a
@@ -234,10 +230,6 @@
$this->assertEquals( 'Success', $re2['edit']['result'] );
$text = WikiPage::factory( Title::newFromText( $name )
)->getContent( Revision::RAW )->getNativeData();
$this->assertEquals( $text, "== header ==\n\ntest\n\n== header
==\n\ntest" );
- }
-
- function testUndo() {
- $this->markTestIncomplete( "not yet implemented" );
}
function testEditConflict() {
diff --git a/tests/phpunit/includes/api/ApiWatchTest.php
b/tests/phpunit/includes/api/ApiWatchTest.php
index 78bb151..8253989 100644
--- a/tests/phpunit/includes/api/ApiWatchTest.php
+++ b/tests/phpunit/includes/api/ApiWatchTest.php
@@ -145,23 +145,4 @@
}
}
}
-
- /**
- */
- function testWatchDelete() {
- $tokens = $this->getTokens();
-
- $data = $this->doApiRequest( array(
- 'action' => 'delete',
- 'token' => $tokens['deletetoken'],
- 'title' => 'Help:UTPage' ) );
- $this->assertArrayHasKey( 'delete', $data[0] );
- $this->assertArrayHasKey( 'title', $data[0]['delete'] );
-
- $this->doApiRequest( array(
- 'action' => 'query',
- 'list' => 'watchlist' ) );
-
- $this->markTestIncomplete( 'This test needs to verify the
deleted article was added to the users watchlist' );
- }
}
--
To view, visit https://gerrit.wikimedia.org/r/87612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id15ddb555e059bb6a76c69ca57d09c91e96e91ce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
