jenkins-bot has submitted this change and it was merged.
Change subject: QA#1286 Changed the assertion to from looking at the url to
verifying that the mobileview link exists..tested on all environments and works
correctly
......................................................................
QA#1286 Changed the assertion to from looking at the url to verifying that the
mobileview link exists..tested on all environments and works correctly
Change-Id: I8e28da2574e1411a601766a82a3da8665755a4e6
---
M tests/acceptance/features/step_definitions/footer_steps.rb
M tests/acceptance/features/support/pages/home_page.rb
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/acceptance/features/step_definitions/footer_steps.rb
b/tests/acceptance/features/step_definitions/footer_steps.rb
index e7b2746..8745295 100644
--- a/tests/acceptance/features/step_definitions/footer_steps.rb
+++ b/tests/acceptance/features/step_definitions/footer_steps.rb
@@ -11,7 +11,7 @@
end
Then /^I go to the desktop wiki page$/ do
- @browser.url.should match Regexp.escape('toggle_view_desktop')
+ on(HomePage).mobile_view_element.element.wait_until_present
end
When /^I click on the Content license link$/ do
diff --git a/tests/acceptance/features/support/pages/home_page.rb
b/tests/acceptance/features/support/pages/home_page.rb
index c949d68..0ce397a 100644
--- a/tests/acceptance/features/support/pages/home_page.rb
+++ b/tests/acceptance/features/support/pages/home_page.rb
@@ -47,4 +47,5 @@
a(:edit_history_link, id:'mw-mf-last-modified')
a(:notification_button, id:'secondary-button')
a(:edit_icon_enabled, text:'Edit')
+ li(:mobile_view, id:'footer-places-mobileview')
end
--
To view, visit https://gerrit.wikimedia.org/r/87616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e28da2574e1411a601766a82a3da8665755a4e6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Mgrover <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
