Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove override that only calls parent
......................................................................
Remove override that only calls parent
The comment included inside is not really needed
as this can be seen by looking at getAllowedParams
Change-Id: I525cf420a2b346560e9fbefa0da5706bf81ed737
---
M repo/includes/api/ModifyLangAttribute.php
M repo/includes/api/SetSiteLink.php
2 files changed, 0 insertions(+), 25 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/ModifyLangAttribute.php
b/repo/includes/api/ModifyLangAttribute.php
index f632b63..389f216 100644
--- a/repo/includes/api/ModifyLangAttribute.php
+++ b/repo/includes/api/ModifyLangAttribute.php
@@ -23,17 +23,6 @@
abstract class ModifyLangAttribute extends ModifyEntity {
/**
- * @see \Wikibase\Api\ModifyEntity::validateParameters()
- */
- protected function validateParameters( array $params ) {
- parent::validateParameters( $params );
-
- // Note that language should always exist as a prerequisite for
this
- // call to succeed. The param value will not always exist
because
- // that signals a label to remove.
- }
-
- /**
* Creates a Summary object based on the given API call parameters.
* The Summary will be initializes with the appropriate action name
* and target language. It will not have any summary arguments set.
diff --git a/repo/includes/api/SetSiteLink.php
b/repo/includes/api/SetSiteLink.php
index b2e27c7..5508998 100644
--- a/repo/includes/api/SetSiteLink.php
+++ b/repo/includes/api/SetSiteLink.php
@@ -45,20 +45,6 @@
return $entityContent;
}
- /**
- * Make sure the required parameters are provided and that they are
valid.
- *
- * @since 0.1
- *
- * @param array $params
- */
- protected function validateParameters( array $params ) {
- parent::validateParameters( $params );
-
- // Note that linksite should always exist as a prerequisite for
this
- // call to succeede. The param linktitle will not always exist
because
- // that signals a sitelink to remove.
- }
/**
* @see ApiModifyEntity::modifyEntity()
--
To view, visit https://gerrit.wikimedia.org/r/87605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I525cf420a2b346560e9fbefa0da5706bf81ed737
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
