JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/87630
Change subject: Hygiene: Remove unused .show class from #content_wrapper
......................................................................
Hygiene: Remove unused .show class from #content_wrapper
Also, fix margins for the dynamic page loading spinner.
Change-Id: If14424b110f963040fc2b6c0833fcdad630ee41b
---
M includes/skins/MinervaTemplate.php
M javascripts/common/Page.js
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/30/87630/1
diff --git a/includes/skins/MinervaTemplate.php
b/includes/skins/MinervaTemplate.php
index 0f318c1..9510321 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -109,7 +109,7 @@
protected function renderContentWrapper( $data ) {
$isSpecialPage = $this->getSkin()->getTitle()->isSpecialPage();
?>
- <div class='show' id='content_wrapper'>
+ <div id="content_wrapper">
<?php
if ( !$isSpecialPage ) {
echo $data['prebodytext'];
diff --git a/javascripts/common/Page.js b/javascripts/common/Page.js
index c6cd62d..18ee8ca 100644
--- a/javascripts/common/Page.js
+++ b/javascripts/common/Page.js
@@ -45,7 +45,7 @@
// FIXME: this is horrible, because it makes preRender
run _during_ render...
if ( !options.sections ) {
- $el.empty().addClass( 'loading' );
+ $el.empty().addClass( 'spinner loading' );
// FIXME: api response should also return last
modified timestamp and page_top_level_section_count property
M.pageApi.getPage( pageTitle ).done( function(
pageData ) {
options = $.extend( options, pageData );
@@ -66,7 +66,7 @@
} );
// reset loader
- $el.removeClass( 'loading' );
+ $el.removeClass( 'spinner loading' );
self.emit( 'ready', self );
} ).fail( $.proxy( self, 'emit', 'error' ) );
--
To view, visit https://gerrit.wikimedia.org/r/87630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If14424b110f963040fc2b6c0833fcdad630ee41b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
