Addshore has submitted this change and it was merged.
Change subject: Add TODOs for addIndex and removeIndex methods in SchemaModifier
......................................................................
Add TODOs for addIndex and removeIndex methods in SchemaModifier
Change-Id: If92458b565084806cd27fcefa57be6b23cf91b21
---
M src/MediaWiki/MediaWikiSchemaModifier.php
M src/Schema/SchemaModifier.php
2 files changed, 42 insertions(+), 0 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/MediaWiki/MediaWikiSchemaModifier.php
b/src/MediaWiki/MediaWikiSchemaModifier.php
index b4eb273..4ec2942 100644
--- a/src/MediaWiki/MediaWikiSchemaModifier.php
+++ b/src/MediaWiki/MediaWikiSchemaModifier.php
@@ -5,6 +5,7 @@
use DatabaseBase;
use Wikibase\Database\DBConnectionProvider;
use Wikibase\Database\Schema\Definitions\FieldDefinition;
+use Wikibase\Database\Schema\Definitions\IndexDefinition;
use Wikibase\Database\Schema\FieldAdditionFailedException;
use Wikibase\Database\Schema\FieldRemovalFailedException;
use Wikibase\Database\Schema\SchemaModificationSqlBuilder;
@@ -84,4 +85,28 @@
}
}
+ /**
+ * @see SchemaModifier::removeIndex
+ *
+ * @param string $tableName
+ * @param string $indexName
+ *
+ * TODO: document throws
+ */
+ public function removeIndex( $tableName, $indexName ) {
+ // TODO
+ }
+
+ /**
+ * @see SchemaModifier::addIndex
+ *
+ * @param string $tableName
+ * @param IndexDefinition $index
+ *
+ * TODO: document throws
+ */
+ public function addIndex( $tableName, IndexDefinition $index ) {
+ // TODO
+ }
+
}
diff --git a/src/Schema/SchemaModifier.php b/src/Schema/SchemaModifier.php
index 53fa89c..d9812d5 100644
--- a/src/Schema/SchemaModifier.php
+++ b/src/Schema/SchemaModifier.php
@@ -3,6 +3,7 @@
namespace Wikibase\Database\Schema;
use Wikibase\Database\Schema\Definitions\FieldDefinition;
+use Wikibase\Database\Schema\Definitions\IndexDefinition;
/**
* @since 0.1
@@ -27,4 +28,20 @@
*/
public function addField( $tableName, FieldDefinition $field );
+ /**
+ * @param string $tableName
+ * @param string $indexName
+ *
+ * TODO: document throws
+ */
+ public function removeIndex( $tableName, $indexName );
+
+ /**
+ * @param string $tableName
+ * @param IndexDefinition $index
+ *
+ * TODO: document throws
+ */
+ public function addIndex( $tableName, IndexDefinition $index );
+
}
--
To view, visit https://gerrit.wikimedia.org/r/87673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If92458b565084806cd27fcefa57be6b23cf91b21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
