[MediaWiki-commits] [Gerrit] add TODOs for add/removeIndexSql methods in SchemeaBuilders - change (mediawiki...WikibaseDatabase)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/87680


Change subject: add TODOs for add/removeIndexSql methods in SchemeaBuilders
......................................................................

add TODOs for add/removeIndexSql methods in SchemeaBuilders

Change-Id: I52659a4bdfd2834e1b743c70b9ed6b4629f928e1
---
M src/MySQL/MySQLSchemaSqlBuilder.php
M src/SQLite/SQLiteSchemaSqlBuilder.php
M src/Schema/SchemaModificationSqlBuilder.php
3 files changed, 59 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase 
refs/changes/80/87680/1

diff --git a/src/MySQL/MySQLSchemaSqlBuilder.php 
b/src/MySQL/MySQLSchemaSqlBuilder.php
index 7b96c3a..a4f0c94 100644
--- a/src/MySQL/MySQLSchemaSqlBuilder.php
+++ b/src/MySQL/MySQLSchemaSqlBuilder.php
@@ -4,6 +4,7 @@
 
 use Wikibase\Database\Escaper;
 use Wikibase\Database\Schema\Definitions\FieldDefinition;
+use Wikibase\Database\Schema\Definitions\IndexDefinition;
 use Wikibase\Database\Schema\SchemaModificationSqlBuilder;
 use Wikibase\Database\TableNameFormatter;
 
@@ -48,4 +49,24 @@
                return "ALTER TABLE {$tableName} ADD " . 
$this->fieldSqlBuilder->getFieldSQL( $field );
        }
 
+       /**
+        * @param string $tableName
+        * @param string $indexName
+        *
+        * @return string
+        */
+       public function getRemoveIndexSql( $tableName, $indexName ){
+               //TODO
+       }
+
+       /**
+        * @param string $tableName
+        * @param IndexDefinition $field
+        *
+        * @return string
+        */
+       public function getAddIndexSql( $tableName, IndexDefinition $field ){
+               //TODO
+       }
+
 }
diff --git a/src/SQLite/SQLiteSchemaSqlBuilder.php 
b/src/SQLite/SQLiteSchemaSqlBuilder.php
index 942548b..62cb3de 100644
--- a/src/SQLite/SQLiteSchemaSqlBuilder.php
+++ b/src/SQLite/SQLiteSchemaSqlBuilder.php
@@ -6,6 +6,7 @@
 use Wikibase\Database\Escaper;
 use Wikibase\Database\QueryInterface\QueryInterface;
 use Wikibase\Database\Schema\Definitions\FieldDefinition;
+use Wikibase\Database\Schema\Definitions\IndexDefinition;
 use Wikibase\Database\Schema\SchemaModificationSqlBuilder;
 use Wikibase\Database\Schema\TableDefinitionReader;
 use Wikibase\Database\TableNameFormatter;
@@ -76,4 +77,24 @@
                return "ALTER TABLE {$tableName} ADD COLUMN " . 
$this->fieldSqlBuilder->getFieldSQL( $field );
        }
 
+       /**
+        * @param string $tableName
+        * @param string $indexName
+        *
+        * @return string
+        */
+       public function getRemoveIndexSql( $tableName, $indexName ){
+               //TODO
+       }
+
+       /**
+        * @param string $tableName
+        * @param IndexDefinition $field
+        *
+        * @return string
+        */
+       public function getAddIndexSql( $tableName, IndexDefinition $field ){
+               //TODO
+       }
+
 }
diff --git a/src/Schema/SchemaModificationSqlBuilder.php 
b/src/Schema/SchemaModificationSqlBuilder.php
index 91aa902..bcd23ad 100644
--- a/src/Schema/SchemaModificationSqlBuilder.php
+++ b/src/Schema/SchemaModificationSqlBuilder.php
@@ -3,6 +3,7 @@
 namespace Wikibase\Database\Schema;
 
 use Wikibase\Database\Schema\Definitions\FieldDefinition;
+use Wikibase\Database\Schema\Definitions\IndexDefinition;
 
 /**
  * @since 0.1
@@ -27,4 +28,20 @@
         */
        public function getAddFieldSql( $tableName, FieldDefinition $field );
 
+       /**
+        * @param string $tableName
+        * @param string $indexName
+        *
+        * @return string
+        */
+       public function getRemoveIndexSql( $tableName, $indexName );
+
+       /**
+        * @param string $tableName
+        * @param IndexDefinition $field
+        *
+        * @return string
+        */
+       public function getAddIndexSql( $tableName, IndexDefinition $field );
+
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/87680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52659a4bdfd2834e1b743c70b9ed6b4629f928e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits