Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88024
Change subject: Document class property and break long lines
......................................................................
Document class property and break long lines
Change-Id: Id391dc8911de8b6df0fb95cba58cffee972ca507
---
M includes/specials/SpecialTags.php
1 file changed, 26 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/24/88024/1
diff --git a/includes/specials/SpecialTags.php
b/includes/specials/SpecialTags.php
index 7e34e98..ae0932f 100644
--- a/includes/specials/SpecialTags.php
+++ b/includes/specials/SpecialTags.php
@@ -27,6 +27,10 @@
* @ingroup SpecialPage
*/
class SpecialTags extends SpecialPage {
+ /**
+ * @var array List of defined tags
+ */
+ public $definedTags;
function __construct() {
parent::__construct( 'Tags' );
@@ -55,7 +59,11 @@
$html .= $this->doTagRow( $tag, $hitcount );
}
- $out->addHTML( Xml::tags( 'table', array( 'class' => 'wikitable
sortable mw-tags-table' ), $html ) );
+ $out->addHTML( Xml::tags(
+ 'table',
+ array( 'class' => 'wikitable sortable mw-tags-table' ),
+ $html )
+ );
}
function doTagRow( $tag, $hitcount ) {
@@ -66,7 +74,10 @@
$disp = ChangeTags::tagDescription( $tag );
if ( $user->isAllowed( 'editinterface' ) ) {
$disp .= ' ';
- $editLink = Linker::link( Title::makeTitle(
NS_MEDIAWIKI, "Tag-$tag" ), $this->msg( 'tags-edit' )->escaped() );
+ $editLink = Linker::link(
+ Title::makeTitle( NS_MEDIAWIKI, "Tag-$tag" ),
+ $this->msg( 'tags-edit' )->escaped()
+ );
$disp .= $this->msg( 'parentheses' )->rawParams(
$editLink )->escaped();
}
$newRow .= Xml::tags( 'td', null, $disp );
@@ -75,16 +86,26 @@
$desc = !$msg->exists() ? '' : $msg->parse();
if ( $user->isAllowed( 'editinterface' ) ) {
$desc .= ' ';
- $editDescLink = Linker::link( Title::makeTitle(
NS_MEDIAWIKI, "Tag-$tag-description" ), $this->msg( 'tags-edit' )->escaped() );
+ $editDescLink = Linker::link(
+ Title::makeTitle( NS_MEDIAWIKI,
"Tag-$tag-description" ),
+ $this->msg( 'tags-edit' )->escaped()
+ );
$desc .= $this->msg( 'parentheses' )->rawParams(
$editDescLink )->escaped();
}
$newRow .= Xml::tags( 'td', null, $desc );
- $active = $this->msg( isset( $this->definedTags[$tag] ) ?
'tags-active-yes' : 'tags-active-no' )->escaped();
+ $active = isset( $this->definedTags[$tag] ) ? 'tags-active-yes'
: 'tags-active-no';
+ $active = $this->msg( $active )->escaped();
$newRow .= Xml::tags( 'td', null, $active );
$hitcountLabel = $this->msg( 'tags-hitcount' )->numParams(
$hitcount )->escaped();
- $hitcountLink = Linker::link( SpecialPage::getTitleFor(
'Recentchanges' ), $hitcountLabel, array(), array( 'tagfilter' => $tag ) );
+ $hitcountLink = Linker::link(
+ SpecialPage::getTitleFor( 'Recentchanges' ),
+ $hitcountLabel,
+ array(),
+ array( 'tagfilter' => $tag )
+ );
+
// add raw $hitcount for sorting, because tags-hitcount
contains numbers and letters
$newRow .= Xml::tags( 'td', array( 'data-sort-value' =>
$hitcount ), $hitcountLink );
--
To view, visit https://gerrit.wikimedia.org/r/88024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id391dc8911de8b6df0fb95cba58cffee972ca507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
