Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88034
Change subject: Hide edit notices button properly when none are present
......................................................................
Hide edit notices button properly when none are present
Fix to Iea2c8df1be64d to prevent exception being thrown if no
edit notices are present.
Change-Id: I3da6d7b848d0a0a2ab1a23a5d9c9c3d4eb629024
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/34/88034/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index e0bf6e3..c1c261a 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1281,7 +1281,7 @@
this.toolbarEditNoticesButton.showPopup();
}, this ), 500 );
} else {
- this.toolbarEditNoticesButton.hide();
+ this.toolbarEditNoticesButton.$button.hide();
}
this.toolbarBetaNoticesButton = new ve.ui.PopupButtonWidget( {
--
To view, visit https://gerrit.wikimedia.org/r/88034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3da6d7b848d0a0a2ab1a23a5d9c9c3d4eb629024
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
