Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88039
Change subject: Improve dependency fetching
......................................................................
Improve dependency fetching
Change-Id: If6a0b021a5148b52d2b2db651b3996766e55d691
---
M WikibaseQuery.php
M src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
2 files changed, 12 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQuery
refs/changes/39/88039/1
diff --git a/WikibaseQuery.php b/WikibaseQuery.php
index 4e9ddf6..88aa5a9 100644
--- a/WikibaseQuery.php
+++ b/WikibaseQuery.php
@@ -118,7 +118,9 @@
$dependencyManager->registerBuilder(
'byPropertyValueEntityFinder',
- new
Wikibase\Query\DIC\Builders\ByPropertyValueEntityFinderBuilder()
+ new
Wikibase\Query\DIC\Builders\ByPropertyValueEntityFinderBuilder(
+ \Wikibase\Repo\WikibaseRepo::getDefaultInstance()
+ )
);
$dependencyManager->registerBuilder(
diff --git
a/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
b/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
index dc76db7..017c453 100644
--- a/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
+++ b/src/Wikibase/Query/DIC/Builders/ByPropertyValueEntityFinderBuilder.php
@@ -17,6 +17,12 @@
*/
class ByPropertyValueEntityFinderBuilder extends DependencyBuilder {
+ protected $repo;
+
+ public function __construct( WikibaseRepo $repo ) {
+ $this->repo = $repo;
+ }
+
/**
* @see DependencyBuilder::buildObject
*
@@ -32,9 +38,9 @@
return new ByPropertyValueEntityFinder(
$queryStore->getQueryEngine(),
- DataValueFactory::singleton(), // TODO: get instance
from repo factory
- WikibaseRepo::getDefaultInstance()->getEntityIdParser(),
-
WikibaseRepo::getDefaultInstance()->getEntityIdFormatter()
+ $this->repo->getDataValueFactory(),
+ $this->repo->getEntityIdParser(),
+ $this->repo->getEntityIdFormatter()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/88039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6a0b021a5148b52d2b2db651b3996766e55d691
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuery
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
