jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused $restore from PermissionsTest
......................................................................
Remove unused $restore from PermissionsTest
Change-Id: I68c37f6120f57c23246945f7e0068eb9206b74df
---
M repo/tests/phpunit/includes/api/PermissionsTest.php
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/api/PermissionsTest.php
b/repo/tests/phpunit/includes/api/PermissionsTest.php
index 9021cbf..2299ccf 100644
--- a/repo/tests/phpunit/includes/api/PermissionsTest.php
+++ b/repo/tests/phpunit/includes/api/PermissionsTest.php
@@ -70,7 +70,7 @@
parent::tearDown();
}
- function doPermissionsTest( $action, $params, $permissions = array(),
$expectedError = null, array $restore = array() ) {
+ function doPermissionsTest( $action, $params, $permissions = array(),
$expectedError = null ) {
global $wgUser;
PermissionsHelper::applyPermissions( $permissions );
@@ -155,7 +155,7 @@
'ids' => EntityTestHelper::getId( 'Oslo' ),
);
- $this->doPermissionsTest( 'wbgetentities', $params,
$permissions, $expectedError, array() );
+ $this->doPermissionsTest( 'wbgetentities', $params,
$permissions, $expectedError );
}
function provideAddItemPermissions() {
@@ -194,7 +194,7 @@
'new' => 'item',
);
- $this->doPermissionsTest( 'wbeditentity', $params,
$permissions, $expectedError, array() );
+ $this->doPermissionsTest( 'wbeditentity', $params,
$permissions, $expectedError );
}
function provideSetSiteLinkPermissions() {
@@ -221,7 +221,7 @@
'linktitle' => 'Oslo',
);
- $this->doPermissionsTest( 'wbsetsitelink', $params,
$permissions, $expectedError, array( "Oslo" ) );
+ $this->doPermissionsTest( 'wbsetsitelink', $params,
$permissions, $expectedError );
}
function provideSetLabelPermissions() {
@@ -248,7 +248,7 @@
'value' => 'Oslo',
);
- $this->doPermissionsTest( 'wbsetlabel', $params, $permissions,
$expectedError, array( "Oslo" ) );
+ $this->doPermissionsTest( 'wbsetlabel', $params, $permissions,
$expectedError );
}
function provideSetDescriptionPermissions() {
@@ -275,7 +275,7 @@
'value' => 'Capitol of Norway',
);
- $this->doPermissionsTest( 'wbsetdescription', $params,
$permissions, $expectedError, array( "Oslo" ) );
+ $this->doPermissionsTest( 'wbsetdescription', $params,
$permissions, $expectedError );
}
function provideMergeItemsPermissions() {
@@ -301,7 +301,7 @@
'toid' => EntityTestHelper::getId( 'Empty' ),
);
- $this->doPermissionsTest( 'wbmergeitems', $params,
$permissions, $expectedError, array( "Oslo" , "Empty" ) );
+ $this->doPermissionsTest( 'wbmergeitems', $params,
$permissions, $expectedError );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/87676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68c37f6120f57c23246945f7e0068eb9206b74df
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
