Faidon Liambotis has submitted this change and it was merged.
Change subject: swift: fix python syntax error in ganglia stats
......................................................................
swift: fix python syntax error in ganglia stats
This was a silly error but Jenkins didn't catch it as it's not a .py.
The script is so broken, though, that Jenkins would complain about all
of its other errors, so let's avoid this for now... Hopefully next time
I'll touch this, I'll just rewrite it :)
Change-Id: I5e3a93d2d5e62fb7c1f488cff4f4b0982148a534
---
M files/swift/swift-ganglia-report-global-stats
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Faidon Liambotis: Verified; Looks good to me, approved
diff --git a/files/swift/swift-ganglia-report-global-stats
b/files/swift/swift-ganglia-report-global-stats
index 8c6d032..6ff20df 100755
--- a/files/swift/swift-ganglia-report-global-stats
+++ b/files/swift/swift-ganglia-report-global-stats
@@ -83,8 +83,8 @@
return diff
# submits the metric to ganglia using gmetric, returns the exit code of gmetric
-def submit_to_ganglia(name, value, units, valtype='int32',
- conf='/etc/ganglia/gmond.conf', spoof):
+def submit_to_ganglia(name, value, units, spoof, valtype='int32',
+ conf='/etc/ganglia/gmond.conf'):
retcode = subprocess.call(['/usr/bin/gmetric', '--name', name, '--type',
valtype, '--conf', conf,
'--spoof', spoof, '--value', str(value), '--units', units])
return retcode
--
To view, visit https://gerrit.wikimedia.org/r/88066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e3a93d2d5e62fb7c1f488cff4f4b0982148a534
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
