Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88140


Change subject: Add additional checks to NoClientOrRepoUsageTest
......................................................................

Add additional checks to NoClientOrRepoUsageTest

Change-Id: I22998fe4c704ce6d238ddd630faf1915d2149b2e
---
M lib/tests/phpunit/NoClientOrRepoUsageTest.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/40/88140/1

diff --git a/lib/tests/phpunit/NoClientOrRepoUsageTest.php 
b/lib/tests/phpunit/NoClientOrRepoUsageTest.php
index d5ecf2c..5053dde 100644
--- a/lib/tests/phpunit/NoClientOrRepoUsageTest.php
+++ b/lib/tests/phpunit/NoClientOrRepoUsageTest.php
@@ -14,13 +14,15 @@
 class NoClientOrRepoUsageTest extends \PHPUnit_Framework_TestCase {
 
        public function testNoRepoUsage() {
-               // Increasing of this allowance is forbidden
+               // Increasing this allowance is forbidden
                $this->assertStringNotInLib( 'WikibaseRepo' . '::', 4 );
+               $this->assertStringNotInLib( 'Wikibase\\Repo\\', 4 );
        }
 
        public function testNoClientUsage() {
-               // Increasing of this allowance is forbidden
+               // Increasing this allowance is forbidden
                $this->assertStringNotInLib( 'WikibaseClient' . '::', 3 );
+               $this->assertStringNotInLib( 'Wikibase\\Client\\', 5 );
        }
 
        public function assertStringNotInLib( $string, $maxAllowance = 0 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/88140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22998fe4c704ce6d238ddd630faf1915d2149b2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to