jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove unused function, add annotations
......................................................................
Hygiene: Remove unused function, add annotations
Change-Id: I243890ab85e7730c8abf15c71dc71c083d2a2b64
---
M includes/specials/SpecialUserProfile.php
1 file changed, 2 insertions(+), 12 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialUserProfile.php
b/includes/specials/SpecialUserProfile.php
index 0ee5e87..856aabe 100644
--- a/includes/specials/SpecialUserProfile.php
+++ b/includes/specials/SpecialUserProfile.php
@@ -14,21 +14,10 @@
parent::__construct( 'UserProfile' );
}
- protected function getDaysAgo( $ts ) {
+ protected function getDaysAgo( MWTimestamp $ts ) {
$now = new MWTimestamp();
$diff = $ts->diff( $now );
return $diff->days;
- }
-
- protected function getListHtml( $tag, $attrs, $items ) {
- $html = Html::openElement( $tag, $attrs );
- foreach( $items as $item ) {
- $html .= Html::openElement( 'li' );
- $html .= $item;
- $html .= Html::closeElement( 'li' );
- }
- $html .= Html::closeElement( $tag );
- return $html;
}
/**
@@ -135,6 +124,7 @@
$heading = Html::element( 'h1', array(),
$this->targetUser->getName() );
// set values
+ /** @var SkinMobile $skin */
$skin = $this->getSkin();
$skin->setTemplateVariable( 'secondaryButton', $secondaryButton
);
$skin->setTemplateVariable( 'specialPageHeader', $heading );
--
To view, visit https://gerrit.wikimedia.org/r/88117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I243890ab85e7730c8abf15c71dc71c083d2a2b64
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
