Brion VIBBER has submitted this change and it was merged.
Change subject: Made details scroll down if gap beneath slider after category
delete.
......................................................................
Made details scroll down if gap beneath slider after category delete.
Change-Id: I5163bb90bdecbe36d776334477c41b318422a612
---
M Commons-iOS/DetailScrollViewController.m
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/Commons-iOS/DetailScrollViewController.m
b/Commons-iOS/DetailScrollViewController.m
index 749b279..9436db3 100644
--- a/Commons-iOS/DetailScrollViewController.m
+++ b/Commons-iOS/DetailScrollViewController.m
@@ -1180,6 +1180,7 @@
completion:^(BOOL finished){
[self.selectedRecord removeCategory:category];
[CommonsApp.singleton saveData];
+ [self scrollDownIfGapBeneathDetails];
}];
}
}
@@ -1270,7 +1271,7 @@
float offset = self.view.frame.origin.y - detailsY;
isAnimating = YES;
[self scrollByAmount:-offset withDuration:0.25f delay:0.0f
options:UIViewAnimationCurveEaseOut useXF:NO then:^{
-// [self ensureScrollingDoesNotExceedThreshold];
+ //[self ensureScrollingDoesNotExceedThreshold];
isAnimating = NO;
}];
}
@@ -1289,9 +1290,7 @@
self.view.transform =
CGAffineTransformTranslate(self.view.transform, 0, amount);
}else{
self.viewTopConstraint.constant =
self.view.frame.origin.y + amount;
-
-NSLog(@"self.viewTopConstraint.constant = %f",
self.viewTopConstraint.constant);
-
+ //NSLog(@"self.viewTopConstraint.constant = %f",
self.viewTopConstraint.constant);
[self.view.superview layoutIfNeeded];
}
}
@@ -1318,7 +1317,7 @@
// Scroll to eliminate any gap beneath the table and the bottom of the
delegate's view
float bottomGapHeight = [self getBottomGapHeight];
if (bottomGapHeight > 0.0f) {
-NSLog(@"bottomGapHeight = %f", bottomGapHeight);
+ //NSLog(@"bottomGapHeight = %f", bottomGapHeight);
[self scrollByAmount:bottomGapHeight withDuration:0.25f delay:0.0f
options:UIViewAnimationCurveEaseOut useXF:NO then:nil];
}
}
--
To view, visit https://gerrit.wikimedia.org/r/88160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5163bb90bdecbe36d776334477c41b318422a612
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/commons
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
