Brion VIBBER has submitted this change and it was merged.
Change subject: Scrolling details up no longer hides nav bar.
......................................................................
Scrolling details up no longer hides nav bar.
This keeps the upload button onscreen.
Change-Id: Ia46d440558ec6c6d0710cdb617445c2aa5ca7e34
---
M Commons-iOS/DetailScrollViewController.m
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/Commons-iOS/DetailScrollViewController.m
b/Commons-iOS/DetailScrollViewController.m
index 66dbddf..8af7afb 100644
--- a/Commons-iOS/DetailScrollViewController.m
+++ b/Commons-iOS/DetailScrollViewController.m
@@ -303,7 +303,7 @@
// (needed if details pushed another view controller while details was
scrolled so far up that
// it had caused the nav bar to be hidden - without this extra call to
"makeNavBarRunAwayFromDetails"
// here, when that pushed view gets popped, the nav would overlap the
details)
- [self makeNavBarRunAwayFromDetails];
+ //[self makeNavBarRunAwayFromDetails];
}
-(void)viewDidAppear:(BOOL)animated
@@ -1561,7 +1561,7 @@
float scrollValue = self.view.frame.origin.y / (height -
DETAIL_DOCK_DISTANCE_FROM_BOTTOM);
- [self makeNavBarRunAwayFromDetails];
+ //[self makeNavBarRunAwayFromDetails];
float minChangeToReport = 0.025f;
if (fabsf((scrollValue - lastScrollValue)) > minChangeToReport) {
--
To view, visit https://gerrit.wikimedia.org/r/88167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia46d440558ec6c6d0710cdb617445c2aa5ca7e34
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/commons
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
