Brion VIBBER has submitted this change and it was merged. Change subject: iOS 7 fixes for text field cursor consistency. ......................................................................
iOS 7 fixes for text field cursor consistency. The spacing was off for the cursor in the description text box. The cursor was also not showing for the login text boxes. Change-Id: I5ef761b1ef927eb2aff1e08c27e8f6771098d4f9 --- M Commons-iOS/AppDelegate.m M Commons-iOS/DetailScrollViewController.m 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved diff --git a/Commons-iOS/AppDelegate.m b/Commons-iOS/AppDelegate.m index 34218b4..8b0f225 100644 --- a/Commons-iOS/AppDelegate.m +++ b/Commons-iOS/AppDelegate.m @@ -92,6 +92,10 @@ // Set the color of the nav bar and other system icons [[UIApplication sharedApplication] delegate].window.tintColor = [UIColor whiteColor]; [[UIApplication sharedApplication] setStatusBarStyle:UIStatusBarStyleLightContent]; + + // Set the blinky-cursor color for text boxes + [[UITextField appearance] setTintColor:[UIColor colorWithRed:0.00 green:0.49 blue:0.93 alpha:1.0]]; + [[UITextView appearance] setTintColor:[UIColor colorWithRed:0.00 green:0.49 blue:0.93 alpha:1.0]]; } } diff --git a/Commons-iOS/DetailScrollViewController.m b/Commons-iOS/DetailScrollViewController.m index 52cfb57..7cb309c 100644 --- a/Commons-iOS/DetailScrollViewController.m +++ b/Commons-iOS/DetailScrollViewController.m @@ -163,6 +163,11 @@ self.titleTextField.rightView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 10, 20)]; self.titleTextField.rightViewMode = UITextFieldViewModeAlways; + // Make spacing to left of blinking cursor (iOS 7) consistent with that of the title text field + if ([self.descriptionTextView respondsToSelector:@selector(textContainerInset)]) { + self.descriptionTextView.textContainerInset = UIEdgeInsetsMake(8, 6, 8, 8); + } + self.titleTextField.textColor = DETAIL_EDITABLE_TEXTBOX_TEXT_COLOR; self.descriptionTextView.textColor = DETAIL_EDITABLE_TEXTBOX_TEXT_COLOR; -- To view, visit https://gerrit.wikimedia.org/r/88180 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ef761b1ef927eb2aff1e08c27e8f6771098d4f9 Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/commons Gerrit-Branch: master Gerrit-Owner: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Mhurd <mh...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits