Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88253
Change subject: Move skin support into $wgVisualEditorSupportedSkins
......................................................................
Move skin support into $wgVisualEditorSupportedSkins
$supportedSkins is mostly an artefact of the currently-unrefactored init code
that
will have a sub-class for each skin (so skin's maintainers can add VisualEditor
support without hacking around inside VisualEditor itself), but until then let's
split it out into a global configuration variable at least, so that they have a
hope.
Change-Id: I0742cea6469678c5599768340dfb1f6d2f4debf4
---
M VisualEditor.hooks.php
M VisualEditor.php
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/53/88253/1
diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 6559799..53c7908 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -9,9 +9,6 @@
*/
class VisualEditorHooks {
- /** List of skins VisualEditor integration supports */
- protected static $supportedSkins = array( 'vector', 'apex', 'monobook'
);
-
public static function onSetup() {
global $wgResourceModules, $wgVisualEditorResourceTemplate,
$wgVisualEditorTabMessages;
@@ -280,6 +277,7 @@
$wgVisualEditorPluginModules,
$wgVisualEditorTabPosition,
$wgVisualEditorTabMessages,
+ $wgVisualEditorSupportedSkins,
$wgVisualEditorShowBetaWelcome;
$vars['wgVisualEditorConfig'] = array(
@@ -292,7 +290,7 @@
'enable' =>
$wgDefaultUserOptions['visualeditor-enable'],
'experimental' =>
$wgDefaultUserOptions['visualeditor-enable-experimental'],
),
- 'skins' => self::$supportedSkins,
+ 'skins' => $wgVisualEditorSupportedSkins,
'tabPosition' => $wgVisualEditorTabPosition,
'tabMessages' => $wgVisualEditorTabMessages,
'showBetaWelcome' => $wgVisualEditorShowBetaWelcome,
diff --git a/VisualEditor.php b/VisualEditor.php
index 6a9e71f..012ba10 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -805,6 +805,9 @@
// Namespaces to enable VisualEditor in
$wgVisualEditorNamespaces = $wgContentNamespaces;
+// List of skins VisualEditor integration supports
+$wgVisualEditorSupportedSkins = array( 'vector', 'apex', 'monobook' );
+
// Whether to use change tagging for VisualEditor edits
$wgVisualEditorUseChangeTagging = true;
--
To view, visit https://gerrit.wikimedia.org/r/88253
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0742cea6469678c5599768340dfb1f6d2f4debf4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
