Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88943
Change subject: Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil
......................................................................
Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil
* jquery.mwEmbedUtil is a startup module, which means it loads early
on every page
* This brought in jquery.ui.dialog. However, it was only actually
used in dialogFitWindow. In turn, I can't find anywhere that's used
in TimedMediaHandler or here.
Bug: 55550
Change-Id: I2c5318e7127ee2d410e27f542472b33faa56cd98
---
M MwEmbedModules/MwEmbedSupport/MwEmbedSupport.php
M MwEmbedModules/MwEmbedSupport/jquery/jquery.mwEmbedUtil.js
2 files changed, 0 insertions(+), 28 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MwEmbedSupport
refs/changes/43/88943/1
diff --git a/MwEmbedModules/MwEmbedSupport/MwEmbedSupport.php
b/MwEmbedModules/MwEmbedSupport/MwEmbedSupport.php
index 03c15e5..7158434 100644
--- a/MwEmbedModules/MwEmbedSupport/MwEmbedSupport.php
+++ b/MwEmbedModules/MwEmbedSupport/MwEmbedSupport.php
@@ -70,9 +70,6 @@
"jquery.mwEmbedUtil" => array(
'scripts' => "jquery/jquery.mwEmbedUtil.js",
'debugRaw' => false,
- 'dependencies' => array(
- 'jquery.ui.dialog'
- )
),
'jquery.debouncedresize' => array(
'scripts' => 'jquery/jquery.debouncedresize.js'
diff --git a/MwEmbedModules/MwEmbedSupport/jquery/jquery.mwEmbedUtil.js
b/MwEmbedModules/MwEmbedSupport/jquery/jquery.mwEmbedUtil.js
index 197a922..5307fdd 100644
--- a/MwEmbedModules/MwEmbedSupport/jquery/jquery.mwEmbedUtil.js
+++ b/MwEmbedModules/MwEmbedSupport/jquery/jquery.mwEmbedUtil.js
@@ -92,29 +92,4 @@
);
return this;
};
-
- /**
- * Resize a dialog to fit the window
- *
- * @param {Object}
- * options horizontal and vertical space ( default 50 )
- */
- $.fn.dialogFitWindow = function( options ) {
- var opt_default = { 'hspace':50, 'vspace':50 };
- if ( !options )
- var options = { };
- options = $j.extend( opt_default, options );
- $( this.selector ).dialog( 'option', 'width', $( window
).width() - options.hspace );
- $( this.selector ).dialog( 'option', 'height', $( window
).height() - options.vspace );
- $( this.selector ).dialog( 'option', 'position', 'center' );
- // update the child position: (some of this should be
pushed
- // up-stream via dialog config options
- $( this.selector + '~ .ui-dialog-buttonpane' ).css( {
- 'position':'absolute',
- 'left':'0px',
- 'right':'0px',
- 'bottom':'0px'
- } );
- };
-
} )( jQuery );
--
To view, visit https://gerrit.wikimedia.org/r/88943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c5318e7127ee2d410e27f542472b33faa56cd98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MwEmbedSupport
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
